Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/08/2014 04:08 PM, Jan Kara wrote: On Wed 08-01-14 14:07:03, Raghavendra K T wrote: On 01/06/2014 04:26 PM, Jan Kara wrote: On Mon 06-01-14 15:51:55, Raghavendra K T wrote: --- test file looked something like this: char buf[4096]; int main() { int fd = open("testfile", O_RDONLY);

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/08/2014 04:17 PM, Jan Kara wrote: On Wed 08-01-14 14:19:23, Raghavendra K T wrote: On 01/07/2014 03:43 AM, Andrew Morton wrote: On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T wrote: [...] But having said that I am not able to get an idea of sane implementation to solve this

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Jan Kara
On Wed 08-01-14 14:19:23, Raghavendra K T wrote: > On 01/07/2014 03:43 AM, Andrew Morton wrote: > >On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T > > wrote: > > > >>+ /* > >>+* Readahead onto remote memory is better than no readahead when local > >>+* numa node does not have memory.

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Jan Kara
On Wed 08-01-14 14:07:03, Raghavendra K T wrote: > On 01/06/2014 04:26 PM, Jan Kara wrote: > >On Mon 06-01-14 15:51:55, Raghavendra K T wrote: > >>Currently, max_sane_readahead returns zero on the cpu with empty numa node, > >>fix this by checking for potential empty numa node case during

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/07/2014 03:43 AM, Andrew Morton wrote: On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T wrote: + /* +* Readahead onto remote memory is better than no readahead when local +* numa node does not have memory. We sanitize readahead size depending +* on free

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/06/2014 04:26 PM, Jan Kara wrote: On Mon 06-01-14 15:51:55, Raghavendra K T wrote: Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We also limit the number of readahead pages to 4k.

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/06/2014 04:26 PM, Jan Kara wrote: On Mon 06-01-14 15:51:55, Raghavendra K T wrote: Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We also limit the number of readahead pages to 4k.

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/07/2014 03:43 AM, Andrew Morton wrote: On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: + /* +* Readahead onto remote memory is better than no readahead when local +* numa node does not have memory. We sanitize readahead

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Jan Kara
On Wed 08-01-14 14:07:03, Raghavendra K T wrote: On 01/06/2014 04:26 PM, Jan Kara wrote: On Mon 06-01-14 15:51:55, Raghavendra K T wrote: Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Jan Kara
On Wed 08-01-14 14:19:23, Raghavendra K T wrote: On 01/07/2014 03:43 AM, Andrew Morton wrote: On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: + /* +* Readahead onto remote memory is better than no readahead when local +* numa node does

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/08/2014 04:17 PM, Jan Kara wrote: On Wed 08-01-14 14:19:23, Raghavendra K T wrote: On 01/07/2014 03:43 AM, Andrew Morton wrote: On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: [...] But having said that I am not able to get an idea of sane

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-08 Thread Raghavendra K T
On 01/08/2014 04:08 PM, Jan Kara wrote: On Wed 08-01-14 14:07:03, Raghavendra K T wrote: On 01/06/2014 04:26 PM, Jan Kara wrote: On Mon 06-01-14 15:51:55, Raghavendra K T wrote: --- test file looked something like this: char buf[4096]; int main() { int fd = open(testfile, O_RDONLY);

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-06 Thread Andrew Morton
On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T wrote: > Currently, max_sane_readahead returns zero on the cpu with empty numa node, > fix this by checking for potential empty numa node case during calculation. > We also limit the number of readahead pages to 4k. > > ... > > ---

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-06 Thread Jan Kara
On Mon 06-01-14 15:51:55, Raghavendra K T wrote: > Currently, max_sane_readahead returns zero on the cpu with empty numa node, > fix this by checking for potential empty numa node case during calculation. > We also limit the number of readahead pages to 4k. > > Signed-off-by: Raghavendra K T >

[RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-06 Thread Raghavendra K T
Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We also limit the number of readahead pages to 4k. Signed-off-by: Raghavendra K T --- The current patch limits the readahead into 4k pages (16MB

[RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-06 Thread Raghavendra K T
Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We also limit the number of readahead pages to 4k. Signed-off-by: Raghavendra K T raghavendra...@linux.vnet.ibm.com --- The current patch limits

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-06 Thread Jan Kara
On Mon 06-01-14 15:51:55, Raghavendra K T wrote: Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We also limit the number of readahead pages to 4k. Signed-off-by: Raghavendra K T

Re: [RFC PATCH V3] mm readahead: Fix the readahead fail in case of empty numa node

2014-01-06 Thread Andrew Morton
On Mon, 6 Jan 2014 15:51:55 +0530 Raghavendra K T raghavendra...@linux.vnet.ibm.com wrote: Currently, max_sane_readahead returns zero on the cpu with empty numa node, fix this by checking for potential empty numa node case during calculation. We also limit the number of readahead pages to