Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-27 Thread Rustad, Mark D
> On Feb 27, 2018, at 7:35 AM, David Miller wrote: > > I don't like these helpers on many different levels. > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes.

Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-27 Thread Rustad, Mark D
> On Feb 27, 2018, at 7:35 AM, David Miller wrote: > > I don't like these helpers on many different levels. > So kill off pci_sriov_enable() helper completely, it is unnecessary, > and rename the disable helper so that it says something meaningful to > the reader. Yes. Once pointed out, I

Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-27 Thread David Miller
From: Mark Rustad Date: Sun, 25 Feb 2018 19:19:11 -0800 > diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c > index 677924ae0350..ddd44a9d93ec 100644 > --- a/drivers/pci/iov.c > +++ b/drivers/pci/iov.c > @@ -367,6 +367,54 @@ static void sriov_disable(struct pci_dev

Re: [RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-27 Thread David Miller
From: Mark Rustad Date: Sun, 25 Feb 2018 19:19:11 -0800 > diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c > index 677924ae0350..ddd44a9d93ec 100644 > --- a/drivers/pci/iov.c > +++ b/drivers/pci/iov.c > @@ -367,6 +367,54 @@ static void sriov_disable(struct pci_dev *dev) >

[RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-25 Thread Mark Rustad
Hardware-realized virtio-pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio-net PF and virtio-net VFs. These are hardware realizations of what has been up to now been a software interface. The device in

[RFC PATCH V3] virtio_pci: Add SR-IOV support

2018-02-25 Thread Mark Rustad
Hardware-realized virtio-pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio-net PF and virtio-net VFs. These are hardware realizations of what has been up to now been a software interface. The device in