Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 08:45 PM, Or Gerlitz wrote: On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not work in a guest: So where is the breakage point for you? does 4.4 works? if not, what? Ah, my

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 08:45 PM, Or Gerlitz wrote: On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not work in a guest: So where is the breakage point for you? does 4.4 works? if not, what? Ah, my bad. It is

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Thu, Mar 17, 2016 at 3:40 AM, Alexey Kardashevskiy wrote: > On 03/16/2016 08:45 PM, Or Gerlitz wrote: >> On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy >> wrote: >> >>> Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not >>> work

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Thu, Mar 17, 2016 at 3:40 AM, Alexey Kardashevskiy wrote: > On 03/16/2016 08:45 PM, Or Gerlitz wrote: >> On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy >> wrote: >> >>> Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not >>> work in a guest: >> >> >> So where is

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: > Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not > work in a guest: So where is the breakage point for you? does 4.4 works? if not, what?

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: > Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not > work in a guest: So where is the breakage point for you? does 4.4 works? if not, what?

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 05:09 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 04:49:00PM +1100, Alexey Kardashevskiy wrote: On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today to

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 05:09 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 04:49:00PM +1100, Alexey Kardashevskiy wrote: On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today to

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 04:49:00PM +1100, Alexey Kardashevskiy wrote: > On 03/16/2016 04:10 PM, Eli Cohen wrote: > >On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: > >> > >>So with v4.5 as a host, there is no actual distro available today to > >>use as a guest in the next 6

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 04:49:00PM +1100, Alexey Kardashevskiy wrote: > On 03/16/2016 04:10 PM, Eli Cohen wrote: > >On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: > >> > >>So with v4.5 as a host, there is no actual distro available today to > >>use as a guest in the next 6

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today to use as a guest in the next 6 months (or whatever it takes to backport this partucular patch back there). You

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 04:10 PM, Eli Cohen wrote: On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: So with v4.5 as a host, there is no actual distro available today to use as a guest in the next 6 months (or whatever it takes to backport this partucular patch back there). You

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: > > So with v4.5 as a host, there is no actual distro available today to > use as a guest in the next 6 months (or whatever it takes to > backport this partucular patch back there). > > You could have added a module parameter

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 01:07:58PM +1100, Alexey Kardashevskiy wrote: > > So with v4.5 as a host, there is no actual distro available today to > use as a guest in the next 6 months (or whatever it takes to > backport this partucular patch back there). > > You could have added a module parameter

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/15/2016 09:40 PM, Or Gerlitz wrote: On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/15/2016 09:40 PM, Or Gerlitz wrote: On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver up: mlx4_core:

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 02:29 AM, Christoph Hellwig wrote: On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: Let us check. I was under (the maybe wrong) impression, that before this patch both PF/VF drivers were not operative on some systems, so on those systems it's fair to require the VF

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On 03/16/2016 02:29 AM, Christoph Hellwig wrote: On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: Let us check. I was under (the maybe wrong) impression, that before this patch both PF/VF drivers were not operative on some systems, so on those systems it's fair to require the VF

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: > Let us check. I was under (the maybe wrong) impression, that before this > patch both PF/VF drivers were not operative on some systems, so on those > systems it's fair to require the VF driver to be patched too. To me it sounds like

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 04:23:33PM +0200, Or Gerlitz wrote: > Let us check. I was under (the maybe wrong) impression, that before this > patch both PF/VF drivers were not operative on some systems, so on those > systems it's fair to require the VF driver to be patched too. To me it sounds like

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 2:18 PM, Christoph Hellwig wrote: > On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: >> "[..] Regarding backward compatibility in SR-IOV, if hypervisor has >> this new code, the virtual OS must be updated. [...]" > Which is broken, we can't

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 2:18 PM, Christoph Hellwig wrote: > On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: >> "[..] Regarding backward compatibility in SR-IOV, if hypervisor has >> this new code, the virtual OS must be updated. [...]" > Which is broken, we can't break user or guest

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: > "[..] Regarding backward compatibility in SR-IOV, if hypervisor has > this new code, the virtual OS must be updated. [...]" Which is broken, we can't break user or guest VM ABIs ever.

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: > "[..] Regarding backward compatibility in SR-IOV, if hypervisor has > this new code, the virtual OS must be updated. [...]" Which is broken, we can't break user or guest VM ABIs ever.

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: > This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. > > Without this revert, POWER "pseries" KVM guests with a VF passed to a guest > using VFIO fail to bring the driver up: > > mlx4_core: Mellanox ConnectX

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: > This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. > > Without this revert, POWER "pseries" KVM guests with a VF passed to a guest > using VFIO fail to bring the driver up: > > mlx4_core: Mellanox ConnectX core driver

[RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver up: mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) mlx4_core: Initializing :00:00.0 mlx4_core

[RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. Without this revert, POWER "pseries" KVM guests with a VF passed to a guest using VFIO fail to bring the driver up: mlx4_core: Mellanox ConnectX core driver v2.2-1 (Feb, 2014) mlx4_core: Initializing :00:00.0 mlx4_core