Re: [RFC PATCH linux-next] evm: evm_hmac can be static

[Mimi Zohar]

On Wed, 2018-03-14 at 01:42 +0800, kbuild test robot wrote:
> Fixes: c49fc264be98 ("evm: Move evm_hmac and evm_hash from evm_main.c to 
> evm_crypto.c")
> Signed-off-by: Fengguang Wu 

Thanks!

> ---
>  evm_crypto.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/integrity/evm/evm_crypto.c 
> b/security/integrity/evm/evm_crypto.c
> index fdde9cb..a46fba3 100644
> --- a/security/integrity/evm/evm_crypto.c
> +++ b/security/integrity/evm/evm_crypto.c
> @@ -37,8 +37,8 @@ static DEFINE_MUTEX(mutex);
> 
>  static unsigned long evm_set_key_flags;
> 
> -char * const evm_hmac = "hmac(sha1)";
> -char * const evm_hash = "sha1";
> +static char * const evm_hmac = "hmac(sha1)";
> +static char * const evm_hash = "sha1";
> 
>  /**
>   * evm_set_key() - set EVM HMAC key from the kernel

Re: [RFC PATCH linux-next] evm: evm_hmac can be static

[Mimi Zohar]

On Wed, 2018-03-14 at 01:42 +0800, kbuild test robot wrote:
> Fixes: c49fc264be98 ("evm: Move evm_hmac and evm_hash from evm_main.c to 
> evm_crypto.c")
> Signed-off-by: Fengguang Wu 

Thanks!

> ---
>  evm_crypto.c |4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/integrity/evm/evm_crypto.c 
> b/security/integrity/evm/evm_crypto.c
> index fdde9cb..a46fba3 100644
> --- a/security/integrity/evm/evm_crypto.c
> +++ b/security/integrity/evm/evm_crypto.c
> @@ -37,8 +37,8 @@ static DEFINE_MUTEX(mutex);
> 
>  static unsigned long evm_set_key_flags;
> 
> -char * const evm_hmac = "hmac(sha1)";
> -char * const evm_hash = "sha1";
> +static char * const evm_hmac = "hmac(sha1)";
> +static char * const evm_hash = "sha1";
> 
>  /**
>   * evm_set_key() - set EVM HMAC key from the kernel

[RFC PATCH linux-next] evm: evm_hmac can be static

[kbuild test robot]

Fixes: c49fc264be98 ("evm: Move evm_hmac and evm_hash from evm_main.c to 
evm_crypto.c")
Signed-off-by: Fengguang Wu 
---
 evm_crypto.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/integrity/evm/evm_crypto.c 
b/security/integrity/evm/evm_crypto.c
index fdde9cb..a46fba3 100644
--- a/security/integrity/evm/evm_crypto.c
+++ b/security/integrity/evm/evm_crypto.c
@@ -37,8 +37,8 @@ static DEFINE_MUTEX(mutex);
 
 static unsigned long evm_set_key_flags;
 
-char * const evm_hmac = "hmac(sha1)";
-char * const evm_hash = "sha1";
+static char * const evm_hmac = "hmac(sha1)";
+static char * const evm_hash = "sha1";
 
 /**
  * evm_set_key() - set EVM HMAC key from the kernel

[RFC PATCH linux-next] evm: evm_hmac can be static

[kbuild test robot]

Fixes: c49fc264be98 ("evm: Move evm_hmac and evm_hash from evm_main.c to 
evm_crypto.c")
Signed-off-by: Fengguang Wu 
---
 evm_crypto.c |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/integrity/evm/evm_crypto.c 
b/security/integrity/evm/evm_crypto.c
index fdde9cb..a46fba3 100644
--- a/security/integrity/evm/evm_crypto.c
+++ b/security/integrity/evm/evm_crypto.c
@@ -37,8 +37,8 @@ static DEFINE_MUTEX(mutex);
 
 static unsigned long evm_set_key_flags;
 
-char * const evm_hmac = "hmac(sha1)";
-char * const evm_hash = "sha1";
+static char * const evm_hmac = "hmac(sha1)";
+static char * const evm_hash = "sha1";
 
 /**
  * evm_set_key() - set EVM HMAC key from the kernel