RE: [RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-24 Thread Xing, Cedric
Triplett ; Andrew Lutomirski > ; Huang, Kai ; David Rientjes > ; Jarkko Sakkinen > Subject: Re: [RFC PATCH v1 2/3] x86/vdso: Modify > __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack > > On Mon, Apr 22, 2019 at 5:37 PM Cedric Xing > wrote: > > &g

Re: [RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-23 Thread Andy Lutomirski
> On Apr 23, 2019, at 12:26 PM, Sean Christopherson > wrote: > >> On Mon, Apr 22, 2019 at 05:37:24PM -0700, Cedric Xing wrote: >> The previous __vdso_sgx_enter_enclave() requires enclaves to preserve %rsp, >> which prohibits enclaves from allocating and passing parameters for >> untrusted fun

Re: [RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-23 Thread Sean Christopherson
On Mon, Apr 22, 2019 at 05:37:24PM -0700, Cedric Xing wrote: > The previous __vdso_sgx_enter_enclave() requires enclaves to preserve %rsp, > which prohibits enclaves from allocating and passing parameters for > untrusted function calls (aka. o-calls). > > This patch addresses the problem above by i

Re: [RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-22 Thread Andy Lutomirski
On Mon, Apr 22, 2019 at 5:37 PM Cedric Xing wrote: > > The previous __vdso_sgx_enter_enclave() requires enclaves to preserve %rsp, > which prohibits enclaves from allocating and passing parameters for > untrusted function calls (aka. o-calls). > > This patch addresses the problem above by introduc

[RFC PATCH v1 2/3] x86/vdso: Modify __vdso_sgx_enter_enclave() to allow parameter passing on untrusted stack

2019-04-22 Thread Cedric Xing
The previous __vdso_sgx_enter_enclave() requires enclaves to preserve %rsp, which prohibits enclaves from allocating and passing parameters for untrusted function calls (aka. o-calls). This patch addresses the problem above by introducing a new ABI that preserves %rbp instead of %rsp. Then __vdso_