Re: [RFC PATCH v2] akcipher: Introduce verify_rsa/verify for public key algorithms

2019-01-25 Thread Herbert Xu
On Fri, Jan 18, 2019 at 11:41:00PM +0300, Vitaly Chikunov wrote: > > a) RSA verify works differently (is it just disguised encrypt), > b) We have separate wrapper module for it (pkcs1pad). Thus: > > Old API can not be removed. In other words, we can not replace > .verify_rsa with .verify in these

Re: [RFC PATCH v2] akcipher: Introduce verify_rsa/verify for public key algorithms

2019-01-18 Thread Vitaly Chikunov
David, On Wed, Jan 16, 2019 at 09:27:19PM +0300, Vitaly Chikunov wrote: > On Wed, Jan 16, 2019 at 05:12:20PM +, David Howells wrote: > > Umm... What do I apply this patch to? > > This should go over "crypto: testmgr - split akcipher tests by a key type" > which I sent at 20190107 to

Re: [RFC PATCH v2] akcipher: Introduce verify_rsa/verify for public key algorithms

2019-01-16 Thread Vitaly Chikunov
David, On Wed, Jan 16, 2019 at 05:12:20PM +, David Howells wrote: > Umm... What do I apply this patch to? This should go over "crypto: testmgr - split akcipher tests by a key type" which I sent at 20190107 to linux-crypto. Sorry for the mess. > In your modified

Re: [RFC PATCH v2] akcipher: Introduce verify_rsa/verify for public key algorithms

2019-01-16 Thread David Howells
Umm... What do I apply this patch to? In your modified public_key_verify_signature(): > - sg_init_one(_sg, output, outlen); > - akcipher_request_set_crypt(req, _sg, _sg, sig->s_size, > + sg_init_one(_sg, output, outlen); > + akcipher_request_set_crypt(req, _sg, _sg, sig->s_size,

[RFC PATCH v2] akcipher: Introduce verify_rsa/verify for public key algorithms

2019-01-16 Thread Vitaly Chikunov
To my opinion this new version may fit suggestions of Herbert and David - we only have single general top level crypto_akcipher_verify() call, but two low level ->verify() and ->verify_rsa() calls. Final signature verification is moved from each caller of crypto_akcipher_verify() into