Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2018-01-03 Thread Max Staudt
On 12/31/2017 01:44 PM, Alan Cox wrote: >> So fundamentally I don't think an in-kernel bootsplash is a bad idea. >> But most likely you want this on a highly embedded system, which > > It wouldn't be in kernel on such a device, it'll be in the bootstrap > before (or on a dual core device quite pos

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2018-01-03 Thread Max Staudt
On 12/31/2017 01:35 PM, Alan Cox wrote: > For embedded every KB counts. That is likely to remain the same for some > time because at the end of the day small devices are constrained about the > amount of SRAM you can put on die and the amount of power you can afford > for DRAM. Fascinating, thank

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2018-01-03 Thread Max Staudt
On 12/29/2017 06:13 PM, Jani Nikula wrote: > I think the first issue is the boot manager (e.g. grub) messing up > whatever the BIOS or GOP or whatever drew. If I don't touch any buttons, > I'd prefer the Lenovo or VAIO or NUC or whatever logo stay there. IIRC > some BIOSes let you set up your own s

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-31 Thread Alan Cox
> So fundamentally I don't think an in-kernel bootsplash is a bad idea. > But most likely you want this on a highly embedded system, which It wouldn't be in kernel on such a device, it'll be in the bootstrap before (or on a dual core device quite possibly while) the kernel data is being uncompress

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-31 Thread Alan Cox
On Tue, 19 Dec 2017 19:40:12 +0100 Max Staudt wrote: > On 12/19/2017 06:26 PM, Daniel Vetter wrote: > > On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote: > >> Well, those could enable fbcon if they want the bootsplash. Shouldn't make > >> a difference anyway if they're powerful enough to run

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-29 Thread Jani Nikula
On Tue, 19 Dec 2017, Daniel Vetter wrote: > On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: >> Dear fbdev and fbcon developers, >> >> Thank you very much for your input for the first patch series. >> >> I've included your feedback into this second roll, and kindly ask for >> your opi

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-21 Thread Max Staudt
On 12/21/2017 10:48 AM, Daniel Vetter wrote: > Ok, here's my expectation: > > - fix plymouth and driver loading > > If the plymouth maintainer tells me that's impossible, I'll look at this > again. And no, this does not require killing drivers with SIGBUS, at least > not with drm. Meanwhile I don

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-21 Thread Max Staudt
On 12/21/2017 03:51 PM, Ray Strode wrote: > Hi, > > On Wed, Dec 20, 2017 at 11:44 AM Max Staudt wrote: >> It'd be nice to see this bug fixed, as it happens only occasionally (as is >> the nature of a >> race condition), and was thus really hard to debug. I'm sure it can drive >> people insane,

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-21 Thread Philip Müller
Hi Max, from Manjaro-side we have implemented it now in our v4.14 kernel series and started to test out some themes. Current progress and feedback may be found in our forum: https://forum.manjaro.org/t/bootsplash-provided-by-the-kernel/34467 Best, Philip

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-21 Thread Ray Strode
Hi, On Wed, Dec 20, 2017 at 11:44 AM Max Staudt wrote: > It'd be nice to see this bug fixed, as it happens only occasionally (as is > the nature of a > race condition), and was thus really hard to debug. I'm sure it can drive > people insane, > as they try to find out whether they've disabled C

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-21 Thread Daniel Vetter
On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: > Dear fbdev and fbcon developers, > > Thank you very much for your input for the first patch series. > > I've included your feedback into this second roll, and kindly ask for > your opinion on the new patch series. > > > Changes from

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/20/2017 04:21 PM, Ray Strode wrote: > If we've reached the scenario you're discussing above, the real > failure is that the KMS > driver took too long to load. DRM is the platform graphics api. If > it's not loading > timely enough to show graphics then that's the problem! It sounds > like

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/20/2017 04:19 PM, Daniel Vetter wrote: > On Wed, Dec 20, 2017 at 4:11 PM, Daniel Vetter wrote: >> On Wed, Dec 20, 2017 at 3:55 PM, Max Staudt wrote: >>> On 12/20/2017 11:14 AM, Daniel Vetter wrote: btw since I'm probably sounding a bit too grumpy here: I'd very much support this.

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/20/2017 04:11 PM, Daniel Vetter wrote: > So fundamentally I don't think an in-kernel bootsplash is a bad idea. > But most likely you want this on a highly embedded system, which > probably is compiled for your exact hw, with pretty much everything > built in. Also, no fbcon, maybe even no vt

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Vetter
On Wed, Dec 20, 2017 at 4:19 PM, Daniel Vetter wrote: > On Wed, Dec 20, 2017 at 4:11 PM, Daniel Vetter wrote: >> On Wed, Dec 20, 2017 at 3:55 PM, Max Staudt wrote: >>> On 12/20/2017 11:14 AM, Daniel Vetter wrote: btw since I'm probably sounding a bit too grumpy here: I'd very much supp

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Ray Strode
Hi, > The problem that I am stumbling upon is different: > - the system starts with an FB driver > - after the ShowDelay time, Plymouth opens /dev/fb0 > - the system finally loads the DRM driver, which tries to kick the previous > FB driver > - loading the DRM driver fails because Plymouth st

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Vetter
On Wed, Dec 20, 2017 at 4:11 PM, Daniel Vetter wrote: > On Wed, Dec 20, 2017 at 3:55 PM, Max Staudt wrote: >> On 12/20/2017 11:14 AM, Daniel Vetter wrote: >>> btw since I'm probably sounding a bit too grumpy here: I'd very much >>> support this. I think bootsplash in kernel has a bunch of uses, a

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Vetter
On Wed, Dec 20, 2017 at 3:55 PM, Max Staudt wrote: > On 12/20/2017 11:14 AM, Daniel Vetter wrote: >> btw since I'm probably sounding a bit too grumpy here: I'd very much >> support this. I think bootsplash in kernel has a bunch of uses, and it >> shouldn't be hard to get non-suse people to cheer f

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/20/2017 11:14 AM, Daniel Vetter wrote: > btw since I'm probably sounding a bit too grumpy here: I'd very much > support this. I think bootsplash in kernel has a bunch of uses, and it > shouldn't be hard to get non-suse people to cheer for it (makes merging > easier if it's not just a one-off

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/20/2017 11:06 AM, Neil Armstrong wrote: > My 2cents about this patchset: > You did a good job about all the animation and splash logic, but for me all > this fbcon > stuff is a huge hack, please use a standard and modern display subsystem en > leave fbcon > die alone Thanks for the com

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/20/2017 10:43 AM, Daniel Vetter wrote: > On Tue, Dec 19, 2017 at 07:40:12PM +0100, Max Staudt wrote: >> On 12/19/2017 06:26 PM, Daniel Vetter wrote: >>> So essentially you're telling me that on a current general purpose >>> distro the gfx driver loading is a dumpster fire, and we're fixing >>

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Max Staudt
On 12/19/2017 09:30 PM, Ray Strode wrote: > Hi, > >> For example, having a userspace splash that starts as early as it can >> (thus on vesafb/efifb on a PC) will cause the KMS driver to fail >> reserving the entirety of video RAM, and thus fail loading. This cannot be >> fixed. > well the fix the

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Johannes Thumshirn
On Wed, Dec 20, 2017 at 11:22:36AM +, Daniel Stone wrote: > > Also plymouth grabs the escape character of HPE iLOs, which is a serious > > no-go. > > I'm not entirely sure what this means, but maybe it's best addressed > as a bug report to the Plymouth developers? One of them is in this > thre

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Stone
Hi Johannes, On 20 December 2017 at 11:08, Johannes Thumshirn wrote: > On Tue, Dec 19, 2017 at 05:16:30PM +0100, Daniel Vetter wrote: >> Ok I've realized that my assumptions about why you need this aren't >> So from reading these patches it sounded like you want an in-kernel boot >> splash becaus

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Johannes Thumshirn
On Tue, Dec 19, 2017 at 05:16:30PM +0100, Daniel Vetter wrote: > Ok I've realized that my assumptions about why you need this aren't > holding up. > > So from reading these patches it sounded like you want an in-kernel boot > splash because that would be on the display faster than a userspace one

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Vetter
On Wed, Dec 20, 2017 at 11:06:34AM +0100, Neil Armstrong wrote: > On 20/12/2017 10:43, Daniel Vetter wrote: > > On Tue, Dec 19, 2017 at 07:40:12PM +0100, Max Staudt wrote: > >> On 12/19/2017 06:26 PM, Daniel Vetter wrote: > >>> On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote: > Well, those

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Neil Armstrong
On 20/12/2017 10:43, Daniel Vetter wrote: > On Tue, Dec 19, 2017 at 07:40:12PM +0100, Max Staudt wrote: >> On 12/19/2017 06:26 PM, Daniel Vetter wrote: >>> On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote: Well, those could enable fbcon if they want the bootsplash. Shouldn't make a dif

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-20 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 07:40:12PM +0100, Max Staudt wrote: > On 12/19/2017 06:26 PM, Daniel Vetter wrote: > > On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote: > >> Well, those could enable fbcon if they want the bootsplash. Shouldn't make > >> a difference anyway if they're powerful enough to

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-19 Thread Ray Strode
Hi, > For example, having a userspace splash that starts as early as it can > (thus on vesafb/efifb on a PC) will cause the KMS driver to fail > reserving the entirety of video RAM, and thus fail loading. This cannot be > fixed. well the fix there is to use drm devices... like this: https://cgit

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-19 Thread Max Staudt
On 12/19/2017 06:26 PM, Daniel Vetter wrote: > On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote: >> Well, those could enable fbcon if they want the bootsplash. Shouldn't make a >> difference anyway if they're powerful enough to run Linux. As long as the >> bootsplash is shown, no fbcon drawing

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-19 Thread Daniel Vetter
On Tue, Dec 19, 2017 at 6:04 PM, Max Staudt wrote: > On 12/19/2017 05:16 PM, Daniel Vetter wrote: >> On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: >>> Dear fbdev and fbcon developers, >>> >>> Thank you very much for your input for the first patch series. >>> >>> I've included your fe

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-19 Thread Max Staudt
On 12/19/2017 05:16 PM, Daniel Vetter wrote: > On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: >> Dear fbdev and fbcon developers, >> >> Thank you very much for your input for the first patch series. >> >> I've included your feedback into this second roll, and kindly ask for >> your opi

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-19 Thread Daniel Vetter
On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: > Dear fbdev and fbcon developers, > > Thank you very much for your input for the first patch series. > > I've included your feedback into this second roll, and kindly ask for > your opinion on the new patch series. Ok I've realized tha

Re: [RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-13 Thread Max Staudt
Unfortunately I've forgotten to rebase this patchset to 4.15, so it still builds on top of 4.14. I'll rebase it for the next roll. Max

[RFC PATCH v2 00/13] Kernel based bootsplash

2017-12-13 Thread Max Staudt
Dear fbdev and fbcon developers, Thank you very much for your input for the first patch series. I've included your feedback into this second roll, and kindly ask for your opinion on the new patch series. Changes from v1 to v2: + Added a user space tool to create splash theme files + Bumped t