[RFC PATCH v2 2/2] fscrypt: enable RCU-walk path for .d_revalidate

2018-11-06 Thread Gao Xiang
This patch attempts to enable RCU-walk for fscrypt. It looks harmless at glance and could have better performance than do ref-walk only. Signed-off-by: Gao Xiang --- p.s. In my opinion, it is better to retry for the case of READ_ONCE(dentry->d_parent) != dir rather than just return 0; and

Re: [RFC PATCH v2 2/2] fscrypt: enable RCU-walk path for .d_revalidate

2018-09-10 Thread Gao Xiang
Hi Eric, On 2018/9/11 7:20, Eric Biggers wrote: > Hi Gao, > > On Mon, Sep 10, 2018 at 09:08:57PM +0800, Gao Xiang wrote: >> This patch attempts to enable RCU-walk for fscrypt. >> It looks harmless at glance and could have better >> performance than do ref-walk only. >> >> Signed-off-by: Gao

Re: [RFC PATCH v2 2/2] fscrypt: enable RCU-walk path for .d_revalidate

2018-09-10 Thread Eric Biggers
Hi Gao, On Mon, Sep 10, 2018 at 09:08:57PM +0800, Gao Xiang wrote: > This patch attempts to enable RCU-walk for fscrypt. > It looks harmless at glance and could have better > performance than do ref-walk only. > > Signed-off-by: Gao Xiang > --- > change log v2: > -

[RFC PATCH v2 2/2] fscrypt: enable RCU-walk path for .d_revalidate

2018-09-10 Thread Gao Xiang
This patch attempts to enable RCU-walk for fscrypt. It looks harmless at glance and could have better performance than do ref-walk only. Signed-off-by: Gao Xiang --- change log v2: - READ_ONCE(dir->d_parent) -> READ_ONCE(dentry->d_parent) fs/crypto/crypto.c | 22 +-