Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-29 Thread Boris Brezillon
On Wed, 29 Aug 2018 18:29:05 +0800 Liang Yang wrote: > On 8/29/2018 6:08 PM, Liang Yang wrote: > > > > On 8/28/2018 9:26 PM, Boris Brezillon wrote: > >> On Tue, 28 Aug 2018 21:21:48 +0800 > >> Liang Yang wrote: > >> > >>> Hi Boris, > >>> > >>> On 8/24/2018 8:48 PM, Boris Brezillon wrote:

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-29 Thread Boris Brezillon
On Wed, 29 Aug 2018 18:29:05 +0800 Liang Yang wrote: > On 8/29/2018 6:08 PM, Liang Yang wrote: > > > > On 8/28/2018 9:26 PM, Boris Brezillon wrote: > >> On Tue, 28 Aug 2018 21:21:48 +0800 > >> Liang Yang wrote: > >> > >>> Hi Boris, > >>> > >>> On 8/24/2018 8:48 PM, Boris Brezillon wrote:

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-29 Thread Liang Yang
On 8/29/2018 6:08 PM, Liang Yang wrote: On 8/28/2018 9:26 PM, Boris Brezillon wrote: On Tue, 28 Aug 2018 21:21:48 +0800 Liang Yang wrote: Hi Boris, On 8/24/2018 8:48 PM, Boris Brezillon wrote: On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: You have to wait tWB, that's for sure.

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-29 Thread Liang Yang
On 8/29/2018 6:08 PM, Liang Yang wrote: On 8/28/2018 9:26 PM, Boris Brezillon wrote: On Tue, 28 Aug 2018 21:21:48 +0800 Liang Yang wrote: Hi Boris, On 8/24/2018 8:48 PM, Boris Brezillon wrote: On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: You have to wait tWB, that's for sure.

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-29 Thread Liang Yang
On 8/28/2018 9:26 PM, Boris Brezillon wrote: On Tue, 28 Aug 2018 21:21:48 +0800 Liang Yang wrote: Hi Boris, On 8/24/2018 8:48 PM, Boris Brezillon wrote: On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: You have to wait tWB, that's for sure. we have a maximum 32 commands

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-29 Thread Liang Yang
On 8/28/2018 9:26 PM, Boris Brezillon wrote: On Tue, 28 Aug 2018 21:21:48 +0800 Liang Yang wrote: Hi Boris, On 8/24/2018 8:48 PM, Boris Brezillon wrote: On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: You have to wait tWB, that's for sure. we have a maximum 32 commands

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-28 Thread Boris Brezillon
On Tue, 28 Aug 2018 21:21:48 +0800 Liang Yang wrote: > Hi Boris, > > On 8/24/2018 8:48 PM, Boris Brezillon wrote: > > On Wed, 22 Aug 2018 22:08:42 +0800 > > Liang Yang wrote: > > > >>> You have to wait tWB, that's for sure. > >>> > >> we have a maximum 32 commands fifo. when command

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-28 Thread Boris Brezillon
On Tue, 28 Aug 2018 21:21:48 +0800 Liang Yang wrote: > Hi Boris, > > On 8/24/2018 8:48 PM, Boris Brezillon wrote: > > On Wed, 22 Aug 2018 22:08:42 +0800 > > Liang Yang wrote: > > > >>> You have to wait tWB, that's for sure. > >>> > >> we have a maximum 32 commands fifo. when command

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-28 Thread Liang Yang
Hi Boris, On 8/24/2018 8:48 PM, Boris Brezillon wrote: On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: You have to wait tWB, that's for sure. we have a maximum 32 commands fifo. when command is written into NFC_REG_CMD, it doesn't mean that command is executing right now, maybe it

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-28 Thread Liang Yang
Hi Boris, On 8/24/2018 8:48 PM, Boris Brezillon wrote: On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: You have to wait tWB, that's for sure. we have a maximum 32 commands fifo. when command is written into NFC_REG_CMD, it doesn't mean that command is executing right now, maybe it

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-24 Thread Boris Brezillon
On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: > > You have to wait tWB, that's for sure. > > > we have a maximum 32 commands fifo. when command is written into > NFC_REG_CMD, it doesn't mean that command is executing right now, maybe > it is buffering on the queue.Assume one ERASE

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-24 Thread Boris Brezillon
On Wed, 22 Aug 2018 22:08:42 +0800 Liang Yang wrote: > > You have to wait tWB, that's for sure. > > > we have a maximum 32 commands fifo. when command is written into > NFC_REG_CMD, it doesn't mean that command is executing right now, maybe > it is buffering on the queue.Assume one ERASE

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-22 Thread Liang Yang
Hi Boris, There is a question below. please see my comments. Thanks. On 8/17/2018 9:56 PM, Boris Brezillon wrote: On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-22 Thread Liang Yang
Hi Boris, There is a question below. please see my comments. Thanks. On 8/17/2018 9:56 PM, Boris Brezillon wrote: On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-20 Thread Liang Yang
Hi Boris, On 8/17/2018 9:56 PM, Boris Brezillon wrote: On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-20 Thread Liang Yang
Hi Boris, On 8/17/2018 9:56 PM, Boris Brezillon wrote: On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: > Hi Boris, > On 2018/8/2 5:50, Boris Brezillon wrote: > > > Hi Yixun, > > > > On Thu, 19 Jul 2018 17:46:12 +0800 > > Yixun Lan wrote: > > > > I haven't finished reviewing the driver yet (I'll try to do that later > > this week), but I

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
On Fri, 17 Aug 2018 21:03:59 +0800 Liang Yang wrote: > Hi Boris, > On 2018/8/2 5:50, Boris Brezillon wrote: > > > Hi Yixun, > > > > On Thu, 19 Jul 2018 17:46:12 +0800 > > Yixun Lan wrote: > > > > I haven't finished reviewing the driver yet (I'll try to do that later > > this week), but I

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Liang Yang
Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that later this week), but I already pointed a few things to fix/improve. + +static int meson_nfc_exec_op(struct

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Liang Yang
Hi Boris, On 2018/8/2 5:50, Boris Brezillon wrote: Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that later this week), but I already pointed a few things to fix/improve. + +static int meson_nfc_exec_op(struct

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
Hi Yixun, I know I said I would finish reviewing the driver, but I didn't have time to do it, so feel free to send a new version addressing the comments I already made. On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: > +static void meson_nfc_select_chip(struct mtd_info *mtd, int chip) >

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-17 Thread Boris Brezillon
Hi Yixun, I know I said I would finish reviewing the driver, but I didn't have time to do it, so feel free to send a new version addressing the comments I already made. On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: > +static void meson_nfc_select_chip(struct mtd_info *mtd, int chip) >

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-02 Thread Yixun Lan
Hi Boris On 08/02/2018 05:50 AM, Boris Brezillon wrote: > Hi Yixun, > > On Thu, 19 Jul 2018 17:46:12 +0800 > Yixun Lan wrote: > > I haven't finished reviewing the driver yet (I'll try to do that later > this week), but I already pointed a few things to fix/improve. > thanks for the fully

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-02 Thread Yixun Lan
Hi Boris On 08/02/2018 05:50 AM, Boris Brezillon wrote: > Hi Yixun, > > On Thu, 19 Jul 2018 17:46:12 +0800 > Yixun Lan wrote: > > I haven't finished reviewing the driver yet (I'll try to do that later > this week), but I already pointed a few things to fix/improve. > thanks for the fully

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-01 Thread Boris Brezillon
Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that later this week), but I already pointed a few things to fix/improve. > + > +static int meson_nfc_exec_op(struct nand_chip *chip, > + const

Re: [RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-08-01 Thread Boris Brezillon
Hi Yixun, On Thu, 19 Jul 2018 17:46:12 +0800 Yixun Lan wrote: I haven't finished reviewing the driver yet (I'll try to do that later this week), but I already pointed a few things to fix/improve. > + > +static int meson_nfc_exec_op(struct nand_chip *chip, > + const

[RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Yixun Lan
Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs. Signed-off-by: Liang Yang Signed-off-by: Yixun Lan --- drivers/mtd/nand/raw/Kconfig | 10 + drivers/mtd/nand/raw/Makefile |1 + drivers/mtd/nand/raw/meson_nand.c | 1333

[RFC PATCH v2 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-07-19 Thread Yixun Lan
Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs. Signed-off-by: Liang Yang Signed-off-by: Yixun Lan --- drivers/mtd/nand/raw/Kconfig | 10 + drivers/mtd/nand/raw/Makefile |1 + drivers/mtd/nand/raw/meson_nand.c | 1333