Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-29 Thread Dou Liyang
Hi Thomas, On 2018/11/29 6:03, Thomas Gleixner wrote: + affi_desc = kcalloc(nvec, sizeof(*affi_desc), GFP_KERNEL); Why do you want to do that separate allocation here? Just let I thought the irq_create_affinity_desc() also can be called by other functions which may convert

Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-29 Thread Dou Liyang
Hi Bjorn, on 2018/11/29 4:00, Bjorn Helgaas wrote: [+cc linux-pci] Since you mention reports, are there URLs to mailing list archives you can include? OK, I will add it: https://marc.info/?l=linux-kernel=153543887027997=2 - entry = alloc_msi_entry(>dev, nvec, masks); + entry =

Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-28 Thread Thomas Gleixner
Dou, On Thu, 29 Nov 2018, Dou Liyang wrote: > +/** > + * struct irq_affinity_desc - Description for kinds of irq assignements > + * which will be transferred to irqdesc core Please align this proper * struct irq_affinity_desc - Description for kinds of irq assignements *

Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-28 Thread Thomas Gleixner
On Wed, 28 Nov 2018, Bjorn Helgaas wrote: > On Wed, Nov 28, 2018 at 10:45 AM Dou Liyang wrote: > > if (affd) > > - masks = irq_create_affinity_masks(nvec, affd); > > - > > + affi_desc = irq_create_affinity_desc(nvec, affd); > > > > /* MSI Entry

Re: [RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-28 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Nov 28, 2018 at 10:45 AM Dou Liyang wrote: > > Now, Linux just spread the irq affinity to irqdesc core by a cpumask pointer. > if an Vector's affinity is not NULL, it will be marked as managed. > > But, as Kashyap and Sumit reported, in MSI/-x subsystem, the pre/post

[RFC PATCH v3] genirq/affinity: Create and transfer more irq desc info by a new structure

2018-11-28 Thread Dou Liyang
Now, Linux just spread the irq affinity to irqdesc core by a cpumask pointer. if an Vector's affinity is not NULL, it will be marked as managed. But, as Kashyap and Sumit reported, in MSI/-x subsystem, the pre/post vectors may be used to some extra reply queues for performance. their affinities