Re: [RFC PATCH v3 06/14] perf evsel: fix 2 memory leaks
On Fri, May 8, 2020 at 5:39 PM Andi Kleen wrote: > > On Thu, May 07, 2020 at 10:36:21PM -0700, Ian Rogers wrote: > > If allocated, perf_pkg_mask and metric_events need freeing. > > All these patches at the beginning look like straight forward > bug fixes and are really independent of the new features. Thanks, for context I added them after v1 to make it easier to apply the patches. Ian > For them > > Reviewed-by: Andi Kleen > > > > > Signed-off-by: Ian Rogers > > --- > > tools/perf/util/evsel.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > > index 28683b0eb738..05bb46baad6a 100644 > > --- a/tools/perf/util/evsel.c > > +++ b/tools/perf/util/evsel.c > > @@ -1263,6 +1263,8 @@ void evsel__exit(struct evsel *evsel) > > zfree(>group_name); > > zfree(>name); > > zfree(>pmu_name); > > + zfree(>per_pkg_mask); > > + zfree(>metric_events); > > perf_evsel__object.fini(evsel); > > } > > > > -- > > 2.26.2.645.ge9eca65c58-goog > >
Re: [RFC PATCH v3 06/14] perf evsel: fix 2 memory leaks
On Thu, May 07, 2020 at 10:36:21PM -0700, Ian Rogers wrote: > If allocated, perf_pkg_mask and metric_events need freeing. All these patches at the beginning look like straight forward bug fixes and are really independent of the new features. For them Reviewed-by: Andi Kleen > > Signed-off-by: Ian Rogers > --- > tools/perf/util/evsel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 28683b0eb738..05bb46baad6a 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -1263,6 +1263,8 @@ void evsel__exit(struct evsel *evsel) > zfree(>group_name); > zfree(>name); > zfree(>pmu_name); > + zfree(>per_pkg_mask); > + zfree(>metric_events); > perf_evsel__object.fini(evsel); > } > > -- > 2.26.2.645.ge9eca65c58-goog >
[RFC PATCH v3 06/14] perf evsel: fix 2 memory leaks
If allocated, perf_pkg_mask and metric_events need freeing. Signed-off-by: Ian Rogers --- tools/perf/util/evsel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 28683b0eb738..05bb46baad6a 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1263,6 +1263,8 @@ void evsel__exit(struct evsel *evsel) zfree(>group_name); zfree(>name); zfree(>pmu_name); + zfree(>per_pkg_mask); + zfree(>metric_events); perf_evsel__object.fini(evsel); } -- 2.26.2.645.ge9eca65c58-goog
