[RFC PATCH v3 10/14] perf metricgroup: always place duration_time last

[Ian Rogers]

If a metric contains the duration_time event then the event is placed
outside of the metric's group of events. Rather than split the group,
make it so the duration_time is immediately after the group.

Signed-off-by: Ian Rogers <irog...@google.com>
---
 tools/perf/util/metricgroup.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
index 7e1725d61c39..2c684fd3c4e3 100644
--- a/tools/perf/util/metricgroup.c
+++ b/tools/perf/util/metricgroup.c
@@ -422,8 +422,8 @@ static void metricgroup__add_metric_weak_group(struct 
strbuf *events,
                                               struct expr_parse_ctx *ctx)
 {
        struct hashmap_entry *cur;
-       size_t bkt, i = 0;
-       bool no_group = false;
+       size_t bkt;
+       bool no_group = true, has_duration = false;
 
        hashmap__for_each_entry((&ctx->ids), cur, bkt) {
                pr_debug("found event %s\n", (const char *)cur->key);
@@ -433,20 +433,20 @@ static void metricgroup__add_metric_weak_group(struct 
strbuf *events,
                 * group.
                 */
                if (!strcmp(cur->key, "duration_time")) {
-                       if (i > 0)
-                               strbuf_addf(events, "}:W,");
-                       strbuf_addf(events, "duration_time");
-                       no_group = true;
+                       has_duration = true;
                        continue;
                }
                strbuf_addf(events, "%s%s",
-                       i == 0 || no_group ? "{" : ",",
+                       no_group ? "{" : ",",
                        (const char *)cur->key);
                no_group = false;
-               i++;
        }
-       if (!no_group)
+       if (!no_group) {
                strbuf_addf(events, "}:W");
+               if (has_duration)
+                       strbuf_addf(events, ",duration_time");
+       } else if (has_duration)
+               strbuf_addf(events, "duration_time");
 }
 
 static void metricgroup__add_metric_non_group(struct strbuf *events,
-- 
2.26.2.645.ge9eca65c58-goog