Re: [RFC PATCH v4 1/3] selftests/x86/sgx: Fix Makefile for SGX selftest

2019-07-14 Thread Jarkko Sakkinen
On Sat, Jul 13, 2019 at 10:29:12AM -0700, Xing, Cedric wrote: > Please note that your patchset hasn't been upstreamed yet. Your Makefile is > problematic to begin with. Technically it's your job to make it work before > sending out any patches. You didn't explain what's done for each line of >

Re: [RFC PATCH v4 1/3] selftests/x86/sgx: Fix Makefile for SGX selftest

2019-07-13 Thread Xing, Cedric
On 7/13/2019 8:15 AM, Jarkko Sakkinen wrote: On Sat, 2019-07-13 at 18:10 +0300, Jarkko Sakkinen wrote: On Fri, 2019-07-12 at 23:51 -0700, Cedric Xing wrote: The original x86/sgx/Makefile didn't work when "x86/sgx" was specified as the test target, nor did it work with "run_tests" as the make

Re: [RFC PATCH v4 1/3] selftests/x86/sgx: Fix Makefile for SGX selftest

2019-07-13 Thread Jarkko Sakkinen
On Sat, 2019-07-13 at 18:10 +0300, Jarkko Sakkinen wrote: > On Fri, 2019-07-12 at 23:51 -0700, Cedric Xing wrote: > > The original x86/sgx/Makefile didn't work when "x86/sgx" was specified as > > the > > test target, nor did it work with "run_tests" as the make target. Yet > > another > >

Re: [RFC PATCH v4 1/3] selftests/x86/sgx: Fix Makefile for SGX selftest

2019-07-13 Thread Jarkko Sakkinen
On Fri, 2019-07-12 at 23:51 -0700, Cedric Xing wrote: > The original x86/sgx/Makefile didn't work when "x86/sgx" was specified as the > test target, nor did it work with "run_tests" as the make target. Yet another > problem was that it breaks 32-bit only build. This patch fixes those problems, >

[RFC PATCH v4 1/3] selftests/x86/sgx: Fix Makefile for SGX selftest

2019-07-13 Thread Cedric Xing
The original x86/sgx/Makefile didn't work when "x86/sgx" was specified as the test target, nor did it work with "run_tests" as the make target. Yet another problem was that it breaks 32-bit only build. This patch fixes those problems, along with adjustments to compiler/linker options and