Re: [RFC RESEND PATCH 4/7] arm64: dts: mt8183: add performance state support of scpsys

[Henry Chen]

On Thu, 2019-01-03 at 10:17 +0530, Viresh Kumar wrote:
> On 02-01-19, 22:09, Henry Chen wrote:
> > Add support for performance state of scpsys on mt8183 platform.
> > 
> > Signed-off-by: Henry Chen 
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 21 +
> >  1 file changed, 21 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
> > b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 47926a7..e396410 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -9,6 +9,7 @@
> >  #include 
> >  #include 
> >  #include 
> > +#include 
> >  
> >  / {
> > compatible = "mediatek,mt8183";
> > @@ -243,6 +244,26 @@
> >   "vpu-3", "vpu-4", "vpu-5";
> > infracfg = <>;
> > smi_comm = <_common>;
> > +   operating-points-v2 = <_opp_table>;
> > +   dvfsrc_opp_table: opp-table {
> > +   compatible = "operating-points-v2-mtk-level";
> > +
> > +   dvfsrc_vol_min: opp1 {
> > +   mtk,level = ;
> > +   };
> > +
> > +   dvfsrc_freq_medium: opp2 {
> > +   mtk,level = ;
> > +   };
> > +
> > +   dvfsrc_freq_max: opp3 {
> > +   mtk,level = ;
> > +   };
> > +
> > +   dvfsrc_vol_max: opp4 {
> > +   mtk,level = ;
> > +   };
> > +   };
> > };
> 
> I don't see a patch which makes use of this OPP table using the required-opps
> thing. Where is that ?
> 

Those user drivers of mt8183(e.g. camera, video decoder,...etc) are
still preparing, so I send this RFC series to check if it is feasible
first then they can apply the interface and send for review later.

Henry 

Re: [RFC RESEND PATCH 4/7] arm64: dts: mt8183: add performance state support of scpsys

[Viresh Kumar]

On 02-01-19, 22:09, Henry Chen wrote:
> Add support for performance state of scpsys on mt8183 platform.
> 
> Signed-off-by: Henry Chen 
> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 21 +
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 47926a7..e396410 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -9,6 +9,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  / {
>   compatible = "mediatek,mt8183";
> @@ -243,6 +244,26 @@
> "vpu-3", "vpu-4", "vpu-5";
>   infracfg = <>;
>   smi_comm = <_common>;
> + operating-points-v2 = <_opp_table>;
> + dvfsrc_opp_table: opp-table {
> + compatible = "operating-points-v2-mtk-level";
> +
> + dvfsrc_vol_min: opp1 {
> + mtk,level = ;
> + };
> +
> + dvfsrc_freq_medium: opp2 {
> + mtk,level = ;
> + };
> +
> + dvfsrc_freq_max: opp3 {
> + mtk,level = ;
> + };
> +
> + dvfsrc_vol_max: opp4 {
> + mtk,level = ;
> + };
> + };
>   };

I don't see a patch which makes use of this OPP table using the required-opps
thing. Where is that ?

-- 
viresh

[RFC RESEND PATCH 4/7] arm64: dts: mt8183: add performance state support of scpsys

[Henry Chen]

Add support for performance state of scpsys on mt8183 platform.

Signed-off-by: Henry Chen 
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 21 +
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 47926a7..e396410 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -9,6 +9,7 @@
 #include 
 #include 
 #include 
+#include 
 
 / {
compatible = "mediatek,mt8183";
@@ -243,6 +244,26 @@
  "vpu-3", "vpu-4", "vpu-5";
infracfg = <>;
smi_comm = <_common>;
+   operating-points-v2 = <_opp_table>;
+   dvfsrc_opp_table: opp-table {
+   compatible = "operating-points-v2-mtk-level";
+
+   dvfsrc_vol_min: opp1 {
+   mtk,level = ;
+   };
+
+   dvfsrc_freq_medium: opp2 {
+   mtk,level = ;
+   };
+
+   dvfsrc_freq_max: opp3 {
+   mtk,level = ;
+   };
+
+   dvfsrc_vol_max: opp4 {
+   mtk,level = ;
+   };
+   };
};
 
apmixedsys: syscon@1000c000 {
-- 
1.9.1