Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Viresh Kumar
On 27-12-17, 15:36, Rob Herring wrote: > On Tue, Dec 26, 2017 at 10:45 PM, Viresh Kumar > wrote: > > On 26-12-17, 14:23, Rob Herring wrote: > >> > cpu_opp_table: cpu_opp_table { > >> > compatible = "operating-points-v2"; > >> >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Viresh Kumar
On 27-12-17, 15:36, Rob Herring wrote: > On Tue, Dec 26, 2017 at 10:45 PM, Viresh Kumar > wrote: > > On 26-12-17, 14:23, Rob Herring wrote: > >> > cpu_opp_table: cpu_opp_table { > >> > compatible = "operating-points-v2"; > >> > opp-shared; > >> > > >> >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Rob Herring
On Tue, Dec 26, 2017 at 10:45 PM, Viresh Kumar wrote: > On 26-12-17, 14:23, Rob Herring wrote: >> > cpu_opp_table: cpu_opp_table { >> > compatible = "operating-points-v2"; >> > opp-shared; >> > >> > opp00 { >> >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-27 Thread Rob Herring
On Tue, Dec 26, 2017 at 10:45 PM, Viresh Kumar wrote: > On 26-12-17, 14:23, Rob Herring wrote: >> > cpu_opp_table: cpu_opp_table { >> > compatible = "operating-points-v2"; >> > opp-shared; >> > >> > opp00 { >> >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-26 Thread Viresh Kumar
On 26-12-17, 14:23, Rob Herring wrote: > > cpu_opp_table: cpu_opp_table { > > compatible = "operating-points-v2"; > > opp-shared; > > > > opp00 { > > opp-hz = /bits/ 64 <20800>; > >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-26 Thread Viresh Kumar
On 26-12-17, 14:23, Rob Herring wrote: > > cpu_opp_table: cpu_opp_table { > > compatible = "operating-points-v2"; > > opp-shared; > > > > opp00 { > > opp-hz = /bits/ 64 <20800>; > >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-26 Thread Rob Herring
On Thu, Nov 30, 2017 at 12:59 AM, Viresh Kumar wrote: > On 29-11-17, 16:50, Stephen Boyd wrote: >> Sorry it still makes zero sense to me. It seems that we're trying >> to make the OPP table parsing generic just for the sake of code >> brevity. > > Not just the code but

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-26 Thread Rob Herring
On Thu, Nov 30, 2017 at 12:59 AM, Viresh Kumar wrote: > On 29-11-17, 16:50, Stephen Boyd wrote: >> Sorry it still makes zero sense to me. It seems that we're trying >> to make the OPP table parsing generic just for the sake of code >> brevity. > > Not just the code but bindings as well to make

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-13 Thread Viresh Kumar
On 30-11-17, 12:29, Viresh Kumar wrote: > On 29-11-17, 16:50, Stephen Boyd wrote: > > Sorry it still makes zero sense to me. It seems that we're trying > > to make the OPP table parsing generic just for the sake of code > > brevity. > > Not just the code but bindings as well to make sure we don't

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-12-13 Thread Viresh Kumar
On 30-11-17, 12:29, Viresh Kumar wrote: > On 29-11-17, 16:50, Stephen Boyd wrote: > > Sorry it still makes zero sense to me. It seems that we're trying > > to make the OPP table parsing generic just for the sake of code > > brevity. > > Not just the code but bindings as well to make sure we don't

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-29 Thread Viresh Kumar
On 29-11-17, 16:50, Stephen Boyd wrote: > Sorry it still makes zero sense to me. It seems that we're trying > to make the OPP table parsing generic just for the sake of code > brevity. Not just the code but bindings as well to make sure we don't add a new property (similar to earlier ones) for

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-29 Thread Viresh Kumar
On 29-11-17, 16:50, Stephen Boyd wrote: > Sorry it still makes zero sense to me. It seems that we're trying > to make the OPP table parsing generic just for the sake of code > brevity. Not just the code but bindings as well to make sure we don't add a new property (similar to earlier ones) for

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-29 Thread Stephen Boyd
On 11/28, Ulf Hansson wrote: > On 2 November 2017 at 10:00, Viresh Kumar wrote: > > On 02-11-17, 00:15, Stephen Boyd wrote: > >> Sorry I'm not following. We're going to need to have platform > >> specific code that understands platform specific bindings that > >> aren't

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-29 Thread Stephen Boyd
On 11/28, Ulf Hansson wrote: > On 2 November 2017 at 10:00, Viresh Kumar wrote: > > On 02-11-17, 00:15, Stephen Boyd wrote: > >> Sorry I'm not following. We're going to need to have platform > >> specific code that understands platform specific bindings that > >> aren't shoved into the generic

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-28 Thread Ulf Hansson
On 2 November 2017 at 10:00, Viresh Kumar wrote: > On 02-11-17, 00:15, Stephen Boyd wrote: >> Sorry I'm not following. We're going to need to have platform >> specific code that understands platform specific bindings that >> aren't shoved into the generic OPP bindings. >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-28 Thread Ulf Hansson
On 2 November 2017 at 10:00, Viresh Kumar wrote: > On 02-11-17, 00:15, Stephen Boyd wrote: >> Sorry I'm not following. We're going to need to have platform >> specific code that understands platform specific bindings that >> aren't shoved into the generic OPP bindings. > > At least I am not

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-28 Thread Ulf Hansson
On 31 October 2017 at 13:47, Viresh Kumar wrote: > On some platforms the exact frequency or voltage may be hidden from the > OS by the firmware. Allow such configurations to pass magic values in > the "opp-hz" or the "opp-microvolt" properties, which should be >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-28 Thread Ulf Hansson
On 31 October 2017 at 13:47, Viresh Kumar wrote: > On some platforms the exact frequency or voltage may be hidden from the > OS by the firmware. Allow such configurations to pass magic values in > the "opp-hz" or the "opp-microvolt" properties, which should be > interpreted in a platform

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-02 Thread Viresh Kumar
On 02-11-17, 00:15, Stephen Boyd wrote: > Sorry I'm not following. We're going to need to have platform > specific code that understands platform specific bindings that > aren't shoved into the generic OPP bindings. At least I am not targeting any platform specific binding right now. The way I

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-02 Thread Viresh Kumar
On 02-11-17, 00:15, Stephen Boyd wrote: > Sorry I'm not following. We're going to need to have platform > specific code that understands platform specific bindings that > aren't shoved into the generic OPP bindings. At least I am not targeting any platform specific binding right now. The way I

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-02 Thread Stephen Boyd
On 11/02, Viresh Kumar wrote: > On 01-11-17, 14:43, Stephen Boyd wrote: > > On 11/01, Rob Herring wrote: > > > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar > > > wrote: > > > > On 31 October 2017 at 16:02, Rob Herring wrote: > > > >> Why not a new

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-02 Thread Stephen Boyd
On 11/02, Viresh Kumar wrote: > On 01-11-17, 14:43, Stephen Boyd wrote: > > On 11/01, Rob Herring wrote: > > > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar > > > wrote: > > > > On 31 October 2017 at 16:02, Rob Herring wrote: > > > >> Why not a new property for magic values? opp-magic? Don't we

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Viresh Kumar
On 01-11-17, 14:43, Stephen Boyd wrote: > On 11/01, Rob Herring wrote: > > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar > > wrote: > > > On 31 October 2017 at 16:02, Rob Herring wrote: > > >> Why not a new property for magic values? opp-magic? Don't

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Viresh Kumar
On 01-11-17, 14:43, Stephen Boyd wrote: > On 11/01, Rob Herring wrote: > > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar > > wrote: > > > On 31 October 2017 at 16:02, Rob Herring wrote: > > >> Why not a new property for magic values? opp-magic? Don't we want to > > >> know when we have magic

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Viresh Kumar
On 01-11-17, 15:39, Rob Herring wrote: > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar wrote: > > On 31 October 2017 at 16:02, Rob Herring wrote: > >> Why not a new property for magic values? opp-magic? Don't we want to > >> know when we have magic

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Viresh Kumar
On 01-11-17, 15:39, Rob Herring wrote: > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar wrote: > > On 31 October 2017 at 16:02, Rob Herring wrote: > >> Why not a new property for magic values? opp-magic? Don't we want to > >> know when we have magic values? > > > > I have kept a separate property

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Stephen Boyd
On 11/01, Rob Herring wrote: > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar wrote: > > On 31 October 2017 at 16:02, Rob Herring wrote: > >> Why not a new property for magic values? opp-magic? Don't we want to > >> know when we have magic values? > >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Stephen Boyd
On 11/01, Rob Herring wrote: > On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar wrote: > > On 31 October 2017 at 16:02, Rob Herring wrote: > >> Why not a new property for magic values? opp-magic? Don't we want to > >> know when we have magic values? > > > > I have kept a separate property since

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Rob Herring
On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar wrote: > On 31 October 2017 at 16:02, Rob Herring wrote: >> Why not a new property for magic values? opp-magic? Don't we want to >> know when we have magic values? > > I have kept a separate property since

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-11-01 Thread Rob Herring
On Tue, Oct 31, 2017 at 9:17 PM, Viresh Kumar wrote: > On 31 October 2017 at 16:02, Rob Herring wrote: >> Why not a new property for magic values? opp-magic? Don't we want to >> know when we have magic values? > > I have kept a separate property since beginning (domain-performance-state) > and

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-10-31 Thread Viresh Kumar
On 31 October 2017 at 16:02, Rob Herring wrote: > Why not a new property for magic values? opp-magic? Don't we want to > know when we have magic values? I have kept a separate property since beginning (domain-performance-state) and moved to using these magic values in the

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-10-31 Thread Viresh Kumar
On 31 October 2017 at 16:02, Rob Herring wrote: > Why not a new property for magic values? opp-magic? Don't we want to > know when we have magic values? I have kept a separate property since beginning (domain-performance-state) and moved to using these magic values in the existing field because

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-10-31 Thread Rob Herring
On Tue, Oct 31, 2017 at 7:47 AM, Viresh Kumar wrote: > On some platforms the exact frequency or voltage may be hidden from the > OS by the firmware. Allow such configurations to pass magic values in > the "opp-hz" or the "opp-microvolt" properties, which should be >

Re: [RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-10-31 Thread Rob Herring
On Tue, Oct 31, 2017 at 7:47 AM, Viresh Kumar wrote: > On some platforms the exact frequency or voltage may be hidden from the > OS by the firmware. Allow such configurations to pass magic values in > the "opp-hz" or the "opp-microvolt" properties, which should be > interpreted in a platform

[RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-10-31 Thread Viresh Kumar
On some platforms the exact frequency or voltage may be hidden from the OS by the firmware. Allow such configurations to pass magic values in the "opp-hz" or the "opp-microvolt" properties, which should be interpreted in a platform dependent way. Signed-off-by: Viresh Kumar

[RFC V7 2/2] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values

2017-10-31 Thread Viresh Kumar
On some platforms the exact frequency or voltage may be hidden from the OS by the firmware. Allow such configurations to pass magic values in the "opp-hz" or the "opp-microvolt" properties, which should be interpreted in a platform dependent way. Signed-off-by: Viresh Kumar ---