Re: [RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-17 Thread Luc Van Oostenryck
On Sun, Dec 17, 2017 at 01:46:45PM -0800, Linus Torvalds wrote: > On Sat, Dec 16, 2017 at 5:26 PM, Joe Perches wrote: > >> > >>I'm not expecting you to be able to write a perl script that checks > >>the first line, but we have way too many 200-plus line functions in > >>

Re: [RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-17 Thread Luc Van Oostenryck
On Sun, Dec 17, 2017 at 01:46:45PM -0800, Linus Torvalds wrote: > On Sat, Dec 16, 2017 at 5:26 PM, Joe Perches wrote: > >> > >>I'm not expecting you to be able to write a perl script that checks > >>the first line, but we have way too many 200-plus line functions in > >>the kernel.

Re: [RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-17 Thread Joe Perches
On Sun, 2017-12-17 at 13:46 -0800, Linus Torvalds wrote: > On Sat, Dec 16, 2017 at 5:26 PM, Joe Perches wrote: > > > > > >I'm not expecting you to be able to write a perl script that checks > > >the first line, but we have way too many 200-plus line functions in > > >

Re: [RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-17 Thread Joe Perches
On Sun, 2017-12-17 at 13:46 -0800, Linus Torvalds wrote: > On Sat, Dec 16, 2017 at 5:26 PM, Joe Perches wrote: > > > > > >I'm not expecting you to be able to write a perl script that checks > > >the first line, but we have way too many 200-plus line functions in > > >the kernel. I'd

Re: [RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-17 Thread Linus Torvalds
On Sat, Dec 16, 2017 at 5:26 PM, Joe Perches wrote: >> >>I'm not expecting you to be able to write a perl script that checks >>the first line, but we have way too many 200-plus line functions in >>the kernel. I'd like a warning on anything over 200 lines (a factor

Re: [RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-17 Thread Linus Torvalds
On Sat, Dec 16, 2017 at 5:26 PM, Joe Perches wrote: >> >>I'm not expecting you to be able to write a perl script that checks >>the first line, but we have way too many 200-plus line functions in >>the kernel. I'd like a warning on anything over 200 lines (a factor >>of 4 over

[RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-16 Thread Joe Perches
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote: > - There's no warning for the first paragraph of section 6: > > 6) Functions > > > Functions should be short and sweet, and do just one thing. They should > fit on one or two screenfuls of text (the ISO/ANSI screen size is

[RFC patch] checkpatch: Add a test for long function definitions (>200 lines)

2017-12-16 Thread Joe Perches
On Mon, 2017-12-11 at 14:43 -0800, Matthew Wilcox wrote: > - There's no warning for the first paragraph of section 6: > > 6) Functions > > > Functions should be short and sweet, and do just one thing. They should > fit on one or two screenfuls of text (the ISO/ANSI screen size is