Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Arnd Bergmann
On Monday 19 August 2013, Sebastian Hesselbarth wrote: > On 08/17/13 21:08, Arnd Bergmann wrote: > > On Friday 16 August 2013, Jason Cooper wrote: > > > You should really try to find out what driver uses this. If you have a > > requirement > > that VIRT == PHYS here, the most likely explanation

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Sebastian Hesselbarth
On 08/17/13 21:08, Arnd Bergmann wrote: On Friday 16 August 2013, Jason Cooper wrote: + +#define ARMADA_1500_REG_BASE_VIRT 0xf600 +#define ARMADA_1500_REG_BASE_SIZE 0x0300 + +static struct map_desc armada_1500_io_desc[] __initdata = { + { + .virtual

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Arnd Bergmann
On Monday 19 August 2013, Sebastian Hesselbarth wrote: > AFAIK, there is Armada 1500 (88de3100) used in every Google TV 2nd Gen > devices, some older multimedia boxes also used Armada 1000 (88de3010), > and Chromecast comprises Armada 1500-mini (88de3005). According to the chromecast kernel

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Arnd Bergmann
On Monday 19 August 2013, Sebastian Hesselbarth wrote: > > Note that we should really change the common code to do both the > > of_clk_init() > > and the l2x0_of_init() automatically, but that needs to be done with some > > care, > > in order to not break any of the existing platforms. Would you

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Arnd Bergmann
On Monday 19 August 2013, Sebastian Hesselbarth wrote: Note that we should really change the common code to do both the of_clk_init() and the l2x0_of_init() automatically, but that needs to be done with some care, in order to not break any of the existing platforms. Would you be able

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Arnd Bergmann
On Monday 19 August 2013, Sebastian Hesselbarth wrote: AFAIK, there is Armada 1500 (88de3100) used in every Google TV 2nd Gen devices, some older multimedia boxes also used Armada 1000 (88de3010), and Chromecast comprises Armada 1500-mini (88de3005). According to the chromecast kernel sources

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Sebastian Hesselbarth
On 08/17/13 21:08, Arnd Bergmann wrote: On Friday 16 August 2013, Jason Cooper wrote: + +#define ARMADA_1500_REG_BASE_VIRT 0xf600 +#define ARMADA_1500_REG_BASE_SIZE 0x0300 + +static struct map_desc armada_1500_io_desc[] __initdata = { + { + .virtual

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-19 Thread Arnd Bergmann
On Monday 19 August 2013, Sebastian Hesselbarth wrote: On 08/17/13 21:08, Arnd Bergmann wrote: On Friday 16 August 2013, Jason Cooper wrote: You should really try to find out what driver uses this. If you have a requirement that VIRT == PHYS here, the most likely explanation is that

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-18 Thread Sebastian Hesselbarth
On 08/17/2013 09:08 PM, Arnd Bergmann wrote: On Friday 16 August 2013, Jason Cooper wrote: + +#define ARMADA_1500_REG_BASE_VIRT 0xf600 +#define ARMADA_1500_REG_BASE_SIZE 0x0300 + +static struct map_desc armada_1500_io_desc[] __initdata = { + { + .virtual

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-18 Thread Sebastian Hesselbarth
On 08/17/2013 09:12 PM, Arnd Bergmann wrote: On Friday 16 August 2013, Sebastian Hesselbarth wrote: +config MACH_ARMADA_1500 + bool "Marvell Armada 1500 boards" + select ARMADA_1500_CLK + select ARM_GIC + select CACHE_L2X0 + select CPU_PJ4B + select

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-18 Thread Sebastian Hesselbarth
On 08/17/2013 09:08 PM, Arnd Bergmann wrote: On Friday 16 August 2013, Jason Cooper wrote: + +#define ARMADA_1500_REG_BASE_VIRT 0xf600 +#define ARMADA_1500_REG_BASE_SIZE 0x0300 + +static struct map_desc armada_1500_io_desc[] __initdata = { + { + .virtual

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-18 Thread Sebastian Hesselbarth
On 08/17/2013 09:12 PM, Arnd Bergmann wrote: On Friday 16 August 2013, Sebastian Hesselbarth wrote: +config MACH_ARMADA_1500 + bool Marvell Armada 1500 boards + select ARMADA_1500_CLK + select ARM_GIC + select CACHE_L2X0 + select CPU_PJ4B + select

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Arnd Bergmann
On Saturday 17 August 2013, Arnd Bergmann wrote: > On Friday 16 August 2013, Jason Cooper wrote: > > > + > > You should really try to find out what driver uses this. If you have a > requirement > that VIRT == PHYS here, the most likely explanation is that some driver > accidentally > uses

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Arnd Bergmann
On Friday 16 August 2013, Sebastian Hesselbarth wrote: > +config MACH_ARMADA_1500 > + bool "Marvell Armada 1500 boards" > + select ARMADA_1500_CLK > + select ARM_GIC > + select CACHE_L2X0 > + select CPU_PJ4B > + select DW_APB_TIMER_OF > + select

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Arnd Bergmann
On Friday 16 August 2013, Jason Cooper wrote: > > + > > +#define ARMADA_1500_REG_BASE_VIRT 0xf600 > > +#define ARMADA_1500_REG_BASE_SIZE 0x0300 > > + > > +static struct map_desc armada_1500_io_desc[] __initdata = { > > + { > > + .virtual= ARMADA_1500_REG_BASE_VIRT, >

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Fri, 16 Aug 2013 21:41:38 +0200, Sebastian Hesselbarth wrote: > I am not so sure about the .map_io but I didn't yet fully understand > the mapping requirement. Anyway, it is required for iomap and friends > to work and basically remaps physical register addressed

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Sebastian Hesselbarth
On 08/16/2013 10:48 PM, Jason Cooper wrote: On Fri, Aug 16, 2013 at 09:41:38PM +0200, Sebastian Hesselbarth wrote: This adds initial setup for the Marvell Armada 1500 SoCs. The code is fairly straight-forward, but especially _timer_and_clk_init() can be simplified by using default arch hooks. I

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Sebastian Hesselbarth
On 08/16/2013 10:48 PM, Jason Cooper wrote: On Fri, Aug 16, 2013 at 09:41:38PM +0200, Sebastian Hesselbarth wrote: This adds initial setup for the Marvell Armada 1500 SoCs. The code is fairly straight-forward, but especially _timer_and_clk_init() can be simplified by using default arch hooks. I

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Thomas Petazzoni
Dear Sebastian Hesselbarth, On Fri, 16 Aug 2013 21:41:38 +0200, Sebastian Hesselbarth wrote: I am not so sure about the .map_io but I didn't yet fully understand the mapping requirement. Anyway, it is required for iomap and friends to work and basically remaps physical register addressed onto

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Arnd Bergmann
On Friday 16 August 2013, Jason Cooper wrote: + +#define ARMADA_1500_REG_BASE_VIRT 0xf600 +#define ARMADA_1500_REG_BASE_SIZE 0x0300 + +static struct map_desc armada_1500_io_desc[] __initdata = { + { + .virtual= ARMADA_1500_REG_BASE_VIRT, +

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Arnd Bergmann
On Friday 16 August 2013, Sebastian Hesselbarth wrote: +config MACH_ARMADA_1500 + bool Marvell Armada 1500 boards + select ARMADA_1500_CLK + select ARM_GIC + select CACHE_L2X0 + select CPU_PJ4B + select DW_APB_TIMER_OF + select LOCAL_TIMERS if SMP

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-17 Thread Arnd Bergmann
On Saturday 17 August 2013, Arnd Bergmann wrote: On Friday 16 August 2013, Jason Cooper wrote: + You should really try to find out what driver uses this. If you have a requirement that VIRT == PHYS here, the most likely explanation is that some driver accidentally uses readl/writel

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-16 Thread Jason Cooper
On Fri, Aug 16, 2013 at 09:41:38PM +0200, Sebastian Hesselbarth wrote: > This adds initial setup for the Marvell Armada 1500 SoCs. The code > is fairly straight-forward, but especially _timer_and_clk_init() > can be simplified by using default arch hooks. I will have some time > until mach-mvebu

[RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-16 Thread Sebastian Hesselbarth
This adds initial setup for the Marvell Armada 1500 SoCs. The code is fairly straight-forward, but especially _timer_and_clk_init() can be simplified by using default arch hooks. I will have some time until mach-mvebu is prepared for other SoCs moving over, so I can catch up with latest machine

[RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-16 Thread Sebastian Hesselbarth
This adds initial setup for the Marvell Armada 1500 SoCs. The code is fairly straight-forward, but especially _timer_and_clk_init() can be simplified by using default arch hooks. I will have some time until mach-mvebu is prepared for other SoCs moving over, so I can catch up with latest machine

Re: [RFC v1 5/5] ARM: mvebu: add board init for Armada 1500

2013-08-16 Thread Jason Cooper
On Fri, Aug 16, 2013 at 09:41:38PM +0200, Sebastian Hesselbarth wrote: This adds initial setup for the Marvell Armada 1500 SoCs. The code is fairly straight-forward, but especially _timer_and_clk_init() can be simplified by using default arch hooks. I will have some time until mach-mvebu is