Re: [RFC v5 0/8] Additional kmsg devices

[Andrew Morton]

On Wed, 16 Dec 2015 10:27:57 -0500 Tejun Heo  wrote:

> On Wed, Dec 16, 2015 at 08:47:35AM +0100, Richard Weinberger wrote:
> > > Andrew?  Are you or anyone else interested in picking up this patchset?
> > 
> > I know I'm repeating myself. But this should be done in userspace.
> 
> Nothing in this posting explains why this is being added.  Kinda
> difficult to say yay or nay.

Yes, I've been rather scratching my head over all of that: what does it
all really do, why does it do it, what problem does it solve, what's
the end-user benefit, etc.

There doesn't appear to be a Documentation update in the patchset. 
Perhaps rectifying that omission with a rather good documentation file
would help people to appreciate it all...

Re: [RFC v5 0/8] Additional kmsg devices

[Andrew Morton]

On Wed, 16 Dec 2015 10:27:57 -0500 Tejun Heo  wrote:

> On Wed, Dec 16, 2015 at 08:47:35AM +0100, Richard Weinberger wrote:
> > > Andrew?  Are you or anyone else interested in picking up this patchset?
> > 
> > I know I'm repeating myself. But this should be done in userspace.
> 
> Nothing in this posting explains why this is being added.  Kinda
> difficult to say yay or nay.

Yes, I've been rather scratching my head over all of that: what does it
all really do, why does it do it, what problem does it solve, what's
the end-user benefit, etc.

There doesn't appear to be a Documentation update in the patchset. 
Perhaps rectifying that omission with a rather good documentation file
would help people to appreciate it all...

Re: [RFC v5 0/8] Additional kmsg devices

[Tejun Heo]

Hello,

On Wed, Dec 16, 2015 at 08:47:35AM +0100, Richard Weinberger wrote:
> > Andrew?  Are you or anyone else interested in picking up this patchset?
> 
> I know I'm repeating myself. But this should be done in userspace.

Nothing in this posting explains why this is being added.  Kinda
difficult to say yay or nay.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC v5 0/8] Additional kmsg devices

[Tejun Heo]

Hello,

On Wed, Dec 16, 2015 at 08:47:35AM +0100, Richard Weinberger wrote:
> > Andrew?  Are you or anyone else interested in picking up this patchset?
> 
> I know I'm repeating myself. But this should be done in userspace.

Nothing in this posting explains why this is being added.  Kinda
difficult to say yay or nay.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC v5 0/8] Additional kmsg devices

[Richard Weinberger]

Am 16.12.2015 um 00:46 schrieb Joe Perches:
> On Tue, 2015-10-27 at 11:28 +0100, Paul Osmialowski wrote:
>> Dear All,
>>
>> This is the fifth iteration of Marcin Niesluchowski's serie of patches
>> extending kmsg interface with ability to dynamically create (and destroy)
>> kmsg-like devices which can be used by userspace for logging.
>>
>> This iteration introduces two changes:
>>
>> 1. selftests are rearranged to use kselftest.h API
>>
>> 2. A disputed  patch "add predefined _PID, _TID, _COMM keywords to kmsg*
>>log dict" is removed - no chance it will be ever accepted. It is not
>>critical for this patchset as a whole.
>>
>> Best regards,
>> Paul
>>
>> Marcin Niesluchowski (6):
>>   printk: add one function for storing log in proper format
>>   kmsg: introduce additional kmsg devices support
>>   kmsg: add additional buffers support to memory class
>>   kmsg: add function for adding and deleting additional buffers
>>   kmsg: add ioctl for adding and deleting kmsg* devices
>>   kmsg: add ioctl for kmsg* devices operating on buffers
>>
>> Paul Osmialowski (2):
>>   printk: extract kmsg-related routines from printk.c to kmsg.c
>>   kmsg: selftests
>>
> 
> Andrew?  Are you or anyone else interested in picking up this patchset?

I know I'm repeating myself. But this should be done in userspace.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC v5 0/8] Additional kmsg devices

[Joe Perches]

On Tue, 2015-10-27 at 11:28 +0100, Paul Osmialowski wrote:
> Dear All,
> 
> This is the fifth iteration of Marcin Niesluchowski's serie of patches
> extending kmsg interface with ability to dynamically create (and destroy)
> kmsg-like devices which can be used by userspace for logging.
> 
> This iteration introduces two changes:
> 
> 1. selftests are rearranged to use kselftest.h API
> 
> 2. A disputed  patch "add predefined _PID, _TID, _COMM keywords to kmsg*
>    log dict" is removed - no chance it will be ever accepted. It is not
>    critical for this patchset as a whole.
> 
> Best regards,
> Paul
> 
> Marcin Niesluchowski (6):
>   printk: add one function for storing log in proper format
>   kmsg: introduce additional kmsg devices support
>   kmsg: add additional buffers support to memory class
>   kmsg: add function for adding and deleting additional buffers
>   kmsg: add ioctl for adding and deleting kmsg* devices
>   kmsg: add ioctl for kmsg* devices operating on buffers
> 
> Paul Osmialowski (2):
>   printk: extract kmsg-related routines from printk.c to kmsg.c
>   kmsg: selftests
> 

Andrew?  Are you or anyone else interested in picking up this patchset?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC v5 0/8] Additional kmsg devices

[Joe Perches]

On Tue, 2015-10-27 at 11:28 +0100, Paul Osmialowski wrote:
> Dear All,
> 
> This is the fifth iteration of Marcin Niesluchowski's serie of patches
> extending kmsg interface with ability to dynamically create (and destroy)
> kmsg-like devices which can be used by userspace for logging.
> 
> This iteration introduces two changes:
> 
> 1. selftests are rearranged to use kselftest.h API
> 
> 2. A disputed  patch "add predefined _PID, _TID, _COMM keywords to kmsg*
>    log dict" is removed - no chance it will be ever accepted. It is not
>    critical for this patchset as a whole.
> 
> Best regards,
> Paul
> 
> Marcin Niesluchowski (6):
>   printk: add one function for storing log in proper format
>   kmsg: introduce additional kmsg devices support
>   kmsg: add additional buffers support to memory class
>   kmsg: add function for adding and deleting additional buffers
>   kmsg: add ioctl for adding and deleting kmsg* devices
>   kmsg: add ioctl for kmsg* devices operating on buffers
> 
> Paul Osmialowski (2):
>   printk: extract kmsg-related routines from printk.c to kmsg.c
>   kmsg: selftests
> 

Andrew?  Are you or anyone else interested in picking up this patchset?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC v5 0/8] Additional kmsg devices

[Richard Weinberger]

Am 16.12.2015 um 00:46 schrieb Joe Perches:
> On Tue, 2015-10-27 at 11:28 +0100, Paul Osmialowski wrote:
>> Dear All,
>>
>> This is the fifth iteration of Marcin Niesluchowski's serie of patches
>> extending kmsg interface with ability to dynamically create (and destroy)
>> kmsg-like devices which can be used by userspace for logging.
>>
>> This iteration introduces two changes:
>>
>> 1. selftests are rearranged to use kselftest.h API
>>
>> 2. A disputed  patch "add predefined _PID, _TID, _COMM keywords to kmsg*
>>log dict" is removed - no chance it will be ever accepted. It is not
>>critical for this patchset as a whole.
>>
>> Best regards,
>> Paul
>>
>> Marcin Niesluchowski (6):
>>   printk: add one function for storing log in proper format
>>   kmsg: introduce additional kmsg devices support
>>   kmsg: add additional buffers support to memory class
>>   kmsg: add function for adding and deleting additional buffers
>>   kmsg: add ioctl for adding and deleting kmsg* devices
>>   kmsg: add ioctl for kmsg* devices operating on buffers
>>
>> Paul Osmialowski (2):
>>   printk: extract kmsg-related routines from printk.c to kmsg.c
>>   kmsg: selftests
>>
> 
> Andrew?  Are you or anyone else interested in picking up this patchset?

I know I'm repeating myself. But this should be done in userspace.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RFC v5 0/8] Additional kmsg devices

[Paul Osmialowski]

Dear All,

This is the fifth iteration of Marcin Niesluchowski's serie of patches
extending kmsg interface with ability to dynamically create (and destroy)
kmsg-like devices which can be used by userspace for logging.

This iteration introduces two changes:

1. selftests are rearranged to use kselftest.h API

2. A disputed  patch "add predefined _PID, _TID, _COMM keywords to kmsg*
   log dict" is removed - no chance it will be ever accepted. It is not
   critical for this patchset as a whole.

Best regards,
Paul

Marcin Niesluchowski (6):
  printk: add one function for storing log in proper format
  kmsg: introduce additional kmsg devices support
  kmsg: add additional buffers support to memory class
  kmsg: add function for adding and deleting additional buffers
  kmsg: add ioctl for adding and deleting kmsg* devices
  kmsg: add ioctl for kmsg* devices operating on buffers

Paul Osmialowski (2):
  printk: extract kmsg-related routines from printk.c to kmsg.c
  kmsg: selftests

 Documentation/ioctl/ioctl-number.txt   |1 +
 drivers/char/mem.c |   27 +-
 fs/proc/kmsg.c |4 +-
 include/linux/printk.h |   48 +
 include/uapi/linux/Kbuild  |1 +
 include/uapi/linux/kmsg_ioctl.h|   45 +
 kernel/printk/Makefile |1 +
 kernel/printk/kmsg.c   | 1022 
 kernel/printk/printk.c | 1251 +---
 kernel/printk/printk.h |  256 
 samples/kmsg/kmsg-api.h|   44 +
 tools/testing/selftests/Makefile   |1 +
 tools/testing/selftests/kmsg/.gitignore|1 +
 tools/testing/selftests/kmsg/Makefile  |   30 +
 tools/testing/selftests/kmsg/kmsg-test.c   |  344 ++
 tools/testing/selftests/kmsg/kmsg-test.h   |   28 +
 tools/testing/selftests/kmsg/test-buffer-add-del.c |   78 ++
 .../kmsg/test-buffer-add-write-read-del.c  |  163 +++
 .../kmsg/test-buffer-buf-multithreaded-torture.c   |  201 
 .../selftests/kmsg/test-buffer-buf-torture.c   |  141 +++
 20 files changed, 2722 insertions(+), 965 deletions(-)
 create mode 100644 include/uapi/linux/kmsg_ioctl.h
 create mode 100644 kernel/printk/kmsg.c
 create mode 100644 kernel/printk/printk.h
 create mode 100644 samples/kmsg/kmsg-api.h
 create mode 100644 tools/testing/selftests/kmsg/.gitignore
 create mode 100644 tools/testing/selftests/kmsg/Makefile
 create mode 100644 tools/testing/selftests/kmsg/kmsg-test.c
 create mode 100644 tools/testing/selftests/kmsg/kmsg-test.h
 create mode 100644 tools/testing/selftests/kmsg/test-buffer-add-del.c
 create mode 100644 
tools/testing/selftests/kmsg/test-buffer-add-write-read-del.c
 create mode 100644 
tools/testing/selftests/kmsg/test-buffer-buf-multithreaded-torture.c
 create mode 100644 tools/testing/selftests/kmsg/test-buffer-buf-torture.c

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[RFC v5 0/8] Additional kmsg devices

[Paul Osmialowski]

Dear All,

This is the fifth iteration of Marcin Niesluchowski's serie of patches
extending kmsg interface with ability to dynamically create (and destroy)
kmsg-like devices which can be used by userspace for logging.

This iteration introduces two changes:

1. selftests are rearranged to use kselftest.h API

2. A disputed  patch "add predefined _PID, _TID, _COMM keywords to kmsg*
   log dict" is removed - no chance it will be ever accepted. It is not
   critical for this patchset as a whole.

Best regards,
Paul

Marcin Niesluchowski (6):
  printk: add one function for storing log in proper format
  kmsg: introduce additional kmsg devices support
  kmsg: add additional buffers support to memory class
  kmsg: add function for adding and deleting additional buffers
  kmsg: add ioctl for adding and deleting kmsg* devices
  kmsg: add ioctl for kmsg* devices operating on buffers

Paul Osmialowski (2):
  printk: extract kmsg-related routines from printk.c to kmsg.c
  kmsg: selftests

 Documentation/ioctl/ioctl-number.txt   |1 +
 drivers/char/mem.c |   27 +-
 fs/proc/kmsg.c |4 +-
 include/linux/printk.h |   48 +
 include/uapi/linux/Kbuild  |1 +
 include/uapi/linux/kmsg_ioctl.h|   45 +
 kernel/printk/Makefile |1 +
 kernel/printk/kmsg.c   | 1022 
 kernel/printk/printk.c | 1251 +---
 kernel/printk/printk.h |  256 
 samples/kmsg/kmsg-api.h|   44 +
 tools/testing/selftests/Makefile   |1 +
 tools/testing/selftests/kmsg/.gitignore|1 +
 tools/testing/selftests/kmsg/Makefile  |   30 +
 tools/testing/selftests/kmsg/kmsg-test.c   |  344 ++
 tools/testing/selftests/kmsg/kmsg-test.h   |   28 +
 tools/testing/selftests/kmsg/test-buffer-add-del.c |   78 ++
 .../kmsg/test-buffer-add-write-read-del.c  |  163 +++
 .../kmsg/test-buffer-buf-multithreaded-torture.c   |  201 
 .../selftests/kmsg/test-buffer-buf-torture.c   |  141 +++
 20 files changed, 2722 insertions(+), 965 deletions(-)
 create mode 100644 include/uapi/linux/kmsg_ioctl.h
 create mode 100644 kernel/printk/kmsg.c
 create mode 100644 kernel/printk/printk.h
 create mode 100644 samples/kmsg/kmsg-api.h
 create mode 100644 tools/testing/selftests/kmsg/.gitignore
 create mode 100644 tools/testing/selftests/kmsg/Makefile
 create mode 100644 tools/testing/selftests/kmsg/kmsg-test.c
 create mode 100644 tools/testing/selftests/kmsg/kmsg-test.h
 create mode 100644 tools/testing/selftests/kmsg/test-buffer-add-del.c
 create mode 100644 
tools/testing/selftests/kmsg/test-buffer-add-write-read-del.c
 create mode 100644 
tools/testing/selftests/kmsg/test-buffer-buf-multithreaded-torture.c
 create mode 100644 tools/testing/selftests/kmsg/test-buffer-buf-torture.c

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/