Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread Andreas Gruenbacher
2015-09-02 21:20 GMT+02:00 J. Bruce Fields : > Got it. And maybe it should be obvious, but it might be worth a > sentence in the changelog if it's not already explained elsewhere.--b. Let me try adding a comment. Also I'll fix the next commit which adds MAY_DELETE_SELF here: MAY_DELETE_SELF

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Wed, Sep 02, 2015 at 09:06:32PM +0200, Andreas Gruenbacher wrote: > 2015-09-02 20:53 GMT+02:00 J. Bruce Fields : > >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, > >> struct inode *inode, int mask) > >> * this, letting us set arbitrary permissions for filesystem

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread Andreas Gruenbacher
2015-09-02 20:53 GMT+02:00 J. Bruce Fields : >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, struct >> inode *inode, int mask) >> * this, letting us set arbitrary permissions for filesystem access without >> * changing the "normal" UIDs which are used for other things.

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:00PM +0200, Andreas Gruenbacher wrote: > Richacls distinguish between creating non-directories and directories. To > support that, add an isdir parameter to may_create(). When checking > inode_permission() for create permission, pass in an additional > MAY_CREATE_FILE

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Tue, Aug 04, 2015 at 01:53:00PM +0200, Andreas Gruenbacher wrote: > Richacls distinguish between creating non-directories and directories. To > support that, add an isdir parameter to may_create(). When checking > inode_permission() for create permission, pass in an additional > MAY_CREATE_FILE

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread Andreas Gruenbacher
2015-09-02 21:20 GMT+02:00 J. Bruce Fields : > Got it. And maybe it should be obvious, but it might be worth a > sentence in the changelog if it's not already explained elsewhere.--b. Let me try adding a comment. Also I'll fix the next commit which adds MAY_DELETE_SELF

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread J. Bruce Fields
On Wed, Sep 02, 2015 at 09:06:32PM +0200, Andreas Gruenbacher wrote: > 2015-09-02 20:53 GMT+02:00 J. Bruce Fields : > >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, > >> struct inode *inode, int mask) > >> * this, letting us set arbitrary

Re: [RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-09-02 Thread Andreas Gruenbacher
2015-09-02 20:53 GMT+02:00 J. Bruce Fields : >> @@ -453,7 +453,8 @@ static int sb_permission(struct super_block *sb, struct >> inode *inode, int mask) >> * this, letting us set arbitrary permissions for filesystem access without >> * changing the "normal" UIDs which are

[RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-08-04 Thread Andreas Gruenbacher
Richacls distinguish between creating non-directories and directories. To support that, add an isdir parameter to may_create(). When checking inode_permission() for create permission, pass in an additional MAY_CREATE_FILE or MAY_CREATE_DIR mask flag. To allow checking for delete *and* create

[RFC v6 02/40] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags

2015-08-04 Thread Andreas Gruenbacher
Richacls distinguish between creating non-directories and directories. To support that, add an isdir parameter to may_create(). When checking inode_permission() for create permission, pass in an additional MAY_CREATE_FILE or MAY_CREATE_DIR mask flag. To allow checking for delete *and* create