Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD

[Anand Moon]

Hi Neil,

On Mon, 7 Oct 2019 at 19:51, Neil Armstrong  wrote:
>
> On 07/10/2019 15:16, Anand Moon wrote:
> > As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD
> > regulator. Also add TFLASH_VDD_EN signal name to gpio pin.
> >
> > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> > Cc: Martin Blumenstingl 
> > Cc: Jerome Brunet 
> > Cc: Neil Armstrong 
> > Signed-off-by: Anand Moon 
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
> > b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > index 66262a6ab3fe..6bd23a1e7e1d 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> > @@ -51,9 +51,12 @@
> >   regulator-min-microvolt = <330>;
> >   regulator-max-microvolt = <330>;
> >
> > + /* TFLASH_VDD_EN */
> >   gpio = <_ao GPIOAO_8 GPIO_ACTIVE_HIGH>;
> >   enable-active-high;
> >   regulator-always-on;
> > + /* U18 FC8731-09VF05NRR */
> > + vin-supply = <_3v3>;
> >   };
> >
> >   tf_io: gpio-regulator-tf_io {
> >
>
> Reviewed-by: Neil Armstrong 

Thanks,

Best Regards
-Anand

Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD

[Neil Armstrong]

On 07/10/2019 15:16, Anand Moon wrote:
> As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD
> regulator. Also add TFLASH_VDD_EN signal name to gpio pin.
> 
> Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
> Cc: Martin Blumenstingl 
> Cc: Jerome Brunet 
> Cc: Neil Armstrong 
> Signed-off-by: Anand Moon 
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
> b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 66262a6ab3fe..6bd23a1e7e1d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -51,9 +51,12 @@
>   regulator-min-microvolt = <330>;
>   regulator-max-microvolt = <330>;
>  
> + /* TFLASH_VDD_EN */
>   gpio = <_ao GPIOAO_8 GPIO_ACTIVE_HIGH>;
>   enable-active-high;
>   regulator-always-on;
> + /* U18 FC8731-09VF05NRR */
> + vin-supply = <_3v3>;
>   };
>  
>   tf_io: gpio-regulator-tf_io {
> 

Reviewed-by: Neil Armstrong 

[RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD

[Anand Moon]

As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD
regulator. Also add TFLASH_VDD_EN signal name to gpio pin.

Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2)
Cc: Martin Blumenstingl 
Cc: Jerome Brunet 
Cc: Neil Armstrong 
Signed-off-by: Anand Moon 
---
 arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts 
b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
index 66262a6ab3fe..6bd23a1e7e1d 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
@@ -51,9 +51,12 @@
regulator-min-microvolt = <330>;
regulator-max-microvolt = <330>;
 
+   /* TFLASH_VDD_EN */
gpio = <_ao GPIOAO_8 GPIO_ACTIVE_HIGH>;
enable-active-high;
regulator-always-on;
+   /* U18 FC8731-09VF05NRR */
+   vin-supply = <_3v3>;
};
 
tf_io: gpio-regulator-tf_io {
-- 
2.23.0