Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

2016-05-30 Thread Laxman Dewangan
On Monday 30 May 2016 02:39 PM, Axel Lin wrote: Current code for .set_ramp_delay() rounds down the value written to register, while the implementation of .set_voltage_time_sel() works on original constraints (not rounded down). Fix the logic in .set_ramp_delay and also remove unused ret_val

Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

2016-05-30 Thread Laxman Dewangan
On Monday 30 May 2016 02:39 PM, Axel Lin wrote: Current code for .set_ramp_delay() rounds down the value written to register, while the implementation of .set_voltage_time_sel() works on original constraints (not rounded down). Fix the logic in .set_ramp_delay and also remove unused ret_val

Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

2016-05-30 Thread Krzysztof Kozlowski
On 05/30/2016 11:09 AM, Axel Lin wrote: > Current code for .set_ramp_delay() rounds down the value written to > register, while the implementation of .set_voltage_time_sel() works on > original constraints (not rounded down). > Fix the logic in .set_ramp_delay and also remove unused ret_val

Re: [RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

2016-05-30 Thread Krzysztof Kozlowski
On 05/30/2016 11:09 AM, Axel Lin wrote: > Current code for .set_ramp_delay() rounds down the value written to > register, while the implementation of .set_voltage_time_sel() works on > original constraints (not rounded down). > Fix the logic in .set_ramp_delay and also remove unused ret_val

[RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

2016-05-30 Thread Axel Lin
Current code for .set_ramp_delay() rounds down the value written to register, while the implementation of .set_voltage_time_sel() works on original constraints (not rounded down). Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin

[RFT][PATCH v2] regulator: max8973: Fix setting ramp delay

2016-05-30 Thread Axel Lin
Current code for .set_ramp_delay() rounds down the value written to register, while the implementation of .set_voltage_time_sel() works on original constraints (not rounded down). Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin --- v2: Update