Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-27 Thread Mark Brown
On Thu, Jul 27, 2017 at 06:51:13PM +0200, Krzysztof Kozlowski wrote: > On Thu, Jul 27, 2017 at 10:41:35AM +0530, Arvind Yadav wrote: > > On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: > > Now s3c2412_i2s.iis_cclk and s3c2412_i2s.iis_pclk are holding "iis" clock. > > Now no one

Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-27 Thread Mark Brown
On Thu, Jul 27, 2017 at 06:51:13PM +0200, Krzysztof Kozlowski wrote: > On Thu, Jul 27, 2017 at 10:41:35AM +0530, Arvind Yadav wrote: > > On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: > > Now s3c2412_i2s.iis_cclk and s3c2412_i2s.iis_pclk are holding "iis" clock. > > Now no one

Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-27 Thread Krzysztof Kozlowski
On Thu, Jul 27, 2017 at 10:41:35AM +0530, Arvind Yadav wrote: > Hi, > > > On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: > > s3c2412_i2s_probe() might fail so driver has to revert work done by > > s3c_i2sv2_probe() (clock enabling). Missing doing this would lead to > > clock

Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-27 Thread Krzysztof Kozlowski
On Thu, Jul 27, 2017 at 10:41:35AM +0530, Arvind Yadav wrote: > Hi, > > > On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: > > s3c2412_i2s_probe() might fail so driver has to revert work done by > > s3c_i2sv2_probe() (clock enabling). Missing doing this would lead to > > clock

Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-26 Thread Arvind Yadav
Hi, On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: s3c2412_i2s_probe() might fail so driver has to revert work done by s3c_i2sv2_probe() (clock enabling). Missing doing this would lead to clock enable in-balance. Signed-off-by: Krzysztof Kozlowski ---

Re: [RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-26 Thread Arvind Yadav
Hi, On Thursday 27 July 2017 12:27 AM, Krzysztof Kozlowski wrote: s3c2412_i2s_probe() might fail so driver has to revert work done by s3c_i2sv2_probe() (clock enabling). Missing doing this would lead to clock enable in-balance. Signed-off-by: Krzysztof Kozlowski --- Please, kindly test on

[RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-26 Thread Krzysztof Kozlowski
s3c2412_i2s_probe() might fail so driver has to revert work done by s3c_i2sv2_probe() (clock enabling). Missing doing this would lead to clock enable in-balance. Signed-off-by: Krzysztof Kozlowski --- Please, kindly test on S3C24xx hardware. ---

[RFT 2/2] ASoC: samsung: Add proper error paths to s3c24xx I2S driver

2017-07-26 Thread Krzysztof Kozlowski
s3c2412_i2s_probe() might fail so driver has to revert work done by s3c_i2sv2_probe() (clock enabling). Missing doing this would lead to clock enable in-balance. Signed-off-by: Krzysztof Kozlowski --- Please, kindly test on S3C24xx hardware. --- sound/soc/samsung/s3c-i2s-v2.c | 9 +