Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check

2015-07-17 Thread Linus Walleij
On Thu, Jul 9, 2015 at 3:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Fi

Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check

2015-07-16 Thread Rabin Vincent
On Thu, Jul 09, 2015 at 10:19:53PM +0900, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlow

Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check

2015-07-16 Thread Linus Walleij
On Thu, Jul 9, 2015 at 3:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Fi

Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check

2015-07-13 Thread Alexandre Courbot
On Thu, Jul 9, 2015 at 10:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. Look obvious enough to be merged without te

[RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check

2015-07-09 Thread Krzysztof Kozlowski
Value returned by devm_ioremap_resource() was checked for non-NULL but devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of error this could lead to dereference of ERR_PTR. Signed-off-by: Krzysztof Kozlowski Fixes: d342571efea8 ("gpio: add ETRAXFS GPIO driver") Cc: --- Patch onl