On 11/20/2013 01:07 AM, Christoph Hellwig wrote:
>> Just stumbled on that too. You need one more, btw, for the sg failure
>> case:
>>
>>
>> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
>> index 588479d58f52..6a680d4de7f1 100644
>> --- a/drivers/block/virtio_blk.c
>> +++
On 11/20/2013 01:04 AM, Christoph Hellwig wrote:
> On Tue, Nov 19, 2013 at 02:43:51PM -0700, Jens Axboe wrote:
>> No, the nr_requests isn't actually relevant in the blk-mq context, the
>> driver sets its own depth. For the above, it's 64 normal commands, and 2
>> reserved. The reserved would be
> Just stumbled on that too. You need one more, btw, for the sg failure
> case:
>
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 588479d58f52..6a680d4de7f1 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -199,15 +199,16 @@
On Tue, Nov 19, 2013 at 02:43:51PM -0700, Jens Axboe wrote:
> No, the nr_requests isn't actually relevant in the blk-mq context, the
> driver sets its own depth. For the above, it's 64 normal commands, and 2
> reserved. The reserved would be for a flush, for instance. If someone
> attempts to
On Tue, Nov 19, 2013 at 02:43:51PM -0700, Jens Axboe wrote:
No, the nr_requests isn't actually relevant in the blk-mq context, the
driver sets its own depth. For the above, it's 64 normal commands, and 2
reserved. The reserved would be for a flush, for instance. If someone
attempts to queue
Just stumbled on that too. You need one more, btw, for the sg failure
case:
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 588479d58f52..6a680d4de7f1 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -199,15 +199,16 @@ static int
On 11/20/2013 01:04 AM, Christoph Hellwig wrote:
On Tue, Nov 19, 2013 at 02:43:51PM -0700, Jens Axboe wrote:
No, the nr_requests isn't actually relevant in the blk-mq context, the
driver sets its own depth. For the above, it's 64 normal commands, and 2
reserved. The reserved would be for a
On 11/20/2013 01:07 AM, Christoph Hellwig wrote:
Just stumbled on that too. You need one more, btw, for the sg failure
case:
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 588479d58f52..6a680d4de7f1 100644
--- a/drivers/block/virtio_blk.c
+++
On Wed, Nov 20 2013, Dave Chinner wrote:
> On Tue, Nov 19, 2013 at 07:02:30PM -0700, Jens Axboe wrote:
> > On Tue, Nov 19 2013, Jens Axboe wrote:
> > > > Looks like a race condition, below works for me, please try.
> > > >
> > > >
> > > > Subject: virtio_blk: fix race condition
> > > >
> > > >
On Tue, Nov 19, 2013 at 07:02:30PM -0700, Jens Axboe wrote:
> On Tue, Nov 19 2013, Jens Axboe wrote:
> > > Looks like a race condition, below works for me, please try.
> > >
> > >
> > > Subject: virtio_blk: fix race condition
> > >
> > > virtqueue_kick() isn't multi-thread safe.
> > >
> > >
On Tue, Nov 19 2013, Jens Axboe wrote:
> > Looks like a race condition, below works for me, please try.
> >
> >
> > Subject: virtio_blk: fix race condition
> >
> > virtqueue_kick() isn't multi-thread safe.
> >
> > Signed-off-by: Shaohua Li
> >
> > diff --git a/drivers/block/virtio_blk.c
On Wed, Nov 20 2013, Shaohua Li wrote:
> On Tue, Nov 19, 2013 at 05:08:58PM -0700, Jens Axboe wrote:
> > On Tue, Nov 19 2013, Jens Axboe wrote:
> > > On Wed, Nov 20 2013, Dave Chinner wrote:
> > > > On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
> > > > > On 11/19/2013 03:42 PM, Jens
On Tue, Nov 19, 2013 at 05:08:58PM -0700, Jens Axboe wrote:
> On Tue, Nov 19 2013, Jens Axboe wrote:
> > On Wed, Nov 20 2013, Dave Chinner wrote:
> > > On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
> > > > On 11/19/2013 03:42 PM, Jens Axboe wrote:
> > > > > On 11/19/2013 02:43 PM,
On Tue, Nov 19 2013, Jens Axboe wrote:
> On Wed, Nov 20 2013, Dave Chinner wrote:
> > On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
> > > On 11/19/2013 03:42 PM, Jens Axboe wrote:
> > > > On 11/19/2013 02:43 PM, Jens Axboe wrote:
> > > >> On 11/19/2013 02:34 PM, Dave Chinner wrote:
>
On Wed, Nov 20 2013, Dave Chinner wrote:
> On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
> > On 11/19/2013 03:42 PM, Jens Axboe wrote:
> > > On 11/19/2013 02:43 PM, Jens Axboe wrote:
> > >> On 11/19/2013 02:34 PM, Dave Chinner wrote:
> > >>> On Tue, Nov 19, 2013 at 02:20:42PM -0700,
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
> On 11/19/2013 03:42 PM, Jens Axboe wrote:
> > On 11/19/2013 02:43 PM, Jens Axboe wrote:
> >> On 11/19/2013 02:34 PM, Dave Chinner wrote:
> >>> On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
> On Tue, Nov 19 2013, Jens
On 11/19/2013 03:42 PM, Jens Axboe wrote:
> On 11/19/2013 02:43 PM, Jens Axboe wrote:
>> On 11/19/2013 02:34 PM, Dave Chinner wrote:
>>> On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
> On Tue, Nov 19 2013, Dave Chinner wrote:
>> Hi
On 11/19/2013 02:43 PM, Jens Axboe wrote:
> On 11/19/2013 02:34 PM, Dave Chinner wrote:
>> On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
>>> On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
> Hi Jens,
>
> I was just running xfstests on
On 11/19/2013 02:34 PM, Dave Chinner wrote:
> On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
>> On Tue, Nov 19 2013, Jens Axboe wrote:
>>> On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer
On 11/19/2013 02:30 PM, Dave Chinner wrote:
> On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
>> On Tue, Nov 19 2013, Christoph Hellwig wrote:
>>> On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
I have no idea if it's related to the above hang, but either way
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
> On Tue, Nov 19 2013, Jens Axboe wrote:
> > On Tue, Nov 19 2013, Dave Chinner wrote:
> > > Hi Jens,
> > >
> > > I was just running xfstests on a 3.13 kernel that has had the block
> > > layer changed merged into it. generic/269 on XFS
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
> On Tue, Nov 19 2013, Christoph Hellwig wrote:
> > On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
> > > I have no idea if it's related to the above hang, but either way
> > > breaking iostat is a major regression
> >
On Tue, Nov 19 2013, Jens Axboe wrote:
> On Tue, Nov 19 2013, Dave Chinner wrote:
> > Hi Jens,
> >
> > I was just running xfstests on a 3.13 kernel that has had the block
> > layer changed merged into it. generic/269 on XFS is hanging on a 2
> > CPU VM using virtio,cache=none for the block
On Tue, Nov 19 2013, Dave Chinner wrote:
> Hi Jens,
>
> I was just running xfstests on a 3.13 kernel that has had the block
> layer changed merged into it. generic/269 on XFS is hanging on a 2
> CPU VM using virtio,cache=none for the block devices under test,
> with many (130+) threads stuck
On 11/19/2013 09:09 AM, Christoph Hellwig wrote:
> On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
>> I have queued up the below.
>
> I don't think that will work. We only set QUEUE_FLAG_IO_STAT in
> blk_init_allocated_queue, which doesn't get called from
> blk_mq_init_queue. That
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
> I have queued up the below.
I don't think that will work. We only set QUEUE_FLAG_IO_STAT in
blk_init_allocated_queue, which doesn't get called from
blk_mq_init_queue. That being said I really don't understand why we
need to have the
On Tue, Nov 19 2013, Christoph Hellwig wrote:
> On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
> > I have no idea if it's related to the above hang, but either way
> > breaking iostat is a major regression
>
> Both of them are most likely due to the conversion of virtio_blk
>
On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
> I have no idea if it's related to the above hang, but either way
> breaking iostat is a major regression
Both of them are most likely due to the conversion of virtio_blk
to the blk-mq code.
I've not seen the hang in my heavy
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it. generic/269 on XFS is hanging on a 2
CPU VM using virtio,cache=none for the block devices under test,
with many (130+) threads stuck below submit_bio() like this:
Call Trace:
[]
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it. generic/269 on XFS is hanging on a 2
CPU VM using virtio,cache=none for the block devices under test,
with many (130+) threads stuck below submit_bio() like this:
Call Trace:
On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
I have no idea if it's related to the above hang, but either way
breaking iostat is a major regression
Both of them are most likely due to the conversion of virtio_blk
to the blk-mq code.
I've not seen the hang in my heavy
On Tue, Nov 19 2013, Christoph Hellwig wrote:
On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
I have no idea if it's related to the above hang, but either way
breaking iostat is a major regression
Both of them are most likely due to the conversion of virtio_blk
to the
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
I have queued up the below.
I don't think that will work. We only set QUEUE_FLAG_IO_STAT in
blk_init_allocated_queue, which doesn't get called from
blk_mq_init_queue. That being said I really don't understand why we
need to have the
On 11/19/2013 09:09 AM, Christoph Hellwig wrote:
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
I have queued up the below.
I don't think that will work. We only set QUEUE_FLAG_IO_STAT in
blk_init_allocated_queue, which doesn't get called from
blk_mq_init_queue. That being
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it. generic/269 on XFS is hanging on a 2
CPU VM using virtio,cache=none for the block devices under test,
with many (130+) threads stuck below
On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it. generic/269 on XFS is hanging on a 2
CPU VM using virtio,cache=none for the block devices under
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Christoph Hellwig wrote:
On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
I have no idea if it's related to the above hang, but either way
breaking iostat is a major regression
Both of
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it. generic/269 on XFS is hanging on a
On 11/19/2013 02:30 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Christoph Hellwig wrote:
On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
I have no idea if it's related to the above hang, but either way
breaking iostat
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it.
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Wed, Nov 20 2013, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe
On Tue, Nov 19 2013, Jens Axboe wrote:
On Wed, Nov 20 2013, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov
On Tue, Nov 19, 2013 at 05:08:58PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Wed, Nov 20 2013, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On Wed, Nov 20 2013, Shaohua Li wrote:
On Tue, Nov 19, 2013 at 05:08:58PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Wed, Nov 20 2013, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
Looks like a race condition, below works for me, please try.
Subject: virtio_blk: fix race condition
virtqueue_kick() isn't multi-thread safe.
Signed-off-by: Shaohua Li s...@fusionio.com
diff --git a/drivers/block/virtio_blk.c
On Tue, Nov 19, 2013 at 07:02:30PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
Looks like a race condition, below works for me, please try.
Subject: virtio_blk: fix race condition
virtqueue_kick() isn't multi-thread safe.
Signed-off-by: Shaohua Li
On Wed, Nov 20 2013, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 07:02:30PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
Looks like a race condition, below works for me, please try.
Subject: virtio_blk: fix race condition
virtqueue_kick() isn't
50 matches
Mail list logo
