Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-10-02 Thread Christopher Lameter
On Sun, 30 Sep 2018, Matthew Wilcox wrote: > > And the patch in mainline has Christoph's ack... > > I'm not saying there's a problem with the patch. It's that the rationale > for backporting doesn't make any damned sense. There's something going > on that nobody understands. This patch is proba

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-30 Thread Matthew Wilcox
On Sun, Sep 30, 2018 at 06:10:26AM -0700, Greg KH wrote: > On Sun, Sep 30, 2018 at 05:50:38AM -0700, Matthew Wilcox wrote: > > On Sun, Sep 30, 2018 at 06:28:21PM +0800, zhong jiang wrote: > > > From: Alexey Dobriyan > > > > > > [ Upstream commit e5d9998f3e09359b372a037a6ac55ba235d95d57 ] > > > >

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-30 Thread Greg KH
On Sun, Sep 30, 2018 at 05:50:38AM -0700, Matthew Wilcox wrote: > On Sun, Sep 30, 2018 at 06:28:21PM +0800, zhong jiang wrote: > > From: Alexey Dobriyan > > > > [ Upstream commit e5d9998f3e09359b372a037a6ac55ba235d95d57 ] > > > > /* > > * cpu_partial determined the maximum numbe

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-30 Thread Matthew Wilcox
On Sun, Sep 30, 2018 at 06:28:21PM +0800, zhong jiang wrote: > From: Alexey Dobriyan > > [ Upstream commit e5d9998f3e09359b372a037a6ac55ba235d95d57 ] > > /* > * cpu_partial determined the maximum number of objects > * kept in the per cpu partial lists of a processor. >

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-30 Thread Greg KH
On Sun, Sep 30, 2018 at 06:28:21PM +0800, zhong jiang wrote: > From: Alexey Dobriyan > > [ Upstream commit e5d9998f3e09359b372a037a6ac55ba235d95d57 ] > > /* > * cpu_partial determined the maximum number of objects > * kept in the per cpu partial lists of a processor. >

[STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-30 Thread zhong jiang
From: Alexey Dobriyan [ Upstream commit e5d9998f3e09359b372a037a6ac55ba235d95d57 ] /* * cpu_partial determined the maximum number of objects * kept in the per cpu partial lists of a processor. */ Can't be negative. I hit a real issue that it will result in a

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-28 Thread zhong jiang
On 2018/9/27 23:46, Greg KH wrote: > On Thu, Sep 27, 2018 at 10:43:40PM +0800, zhong jiang wrote: >> From: Alexey Dobriyan >> >> /* >> * cpu_partial determined the maximum number of objects >> * kept in the per cpu partial lists of a processor. >> */ >> >> Can't

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-27 Thread Greg KH
On Thu, Sep 27, 2018 at 10:43:40PM +0800, zhong jiang wrote: > From: Alexey Dobriyan > > /* > * cpu_partial determined the maximum number of objects > * kept in the per cpu partial lists of a processor. > */ > > Can't be negative. > > I hit a real issue that i

Re: [STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-27 Thread Christopher Lameter
On Thu, 27 Sep 2018, zhong jiang wrote: > From: Alexey Dobriyan > > /* > * cpu_partial determined the maximum number of objects > * kept in the per cpu partial lists of a processor. > */ > > Can't be negative. True. > I hit a real issue that it will result in

[STABLE PATCH] slub: make ->cpu_partial unsigned int

2018-09-27 Thread zhong jiang
From: Alexey Dobriyan /* * cpu_partial determined the maximum number of objects * kept in the per cpu partial lists of a processor. */ Can't be negative. I hit a real issue that it will result in a large number of memory leak. Because Freeing slabs are in inte