Re: [TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node

2014-05-06 Thread Dan Murphy
On 05/06/2014 08:34 AM, Kishon Vijay Abraham I wrote:
> Added *resets* and *reset-names* properies for PCIe dt node.
> The documention for this node can be found @ ../bindings/pci/ti-pci.txt.
>
> Cc: Dan Murphy 
> Signed-off-by: Kishon Vijay Abraham I 
> ---
>  arch/arm/boot/dts/dra7.dtsi |2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 20b1a09..7bc0555 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1031,6 +1031,8 @@
>   ti,hwmods = "pcie1";
>   phys = <_phy>;
>   phy-names = "pcie-phy";
> + resets = <_resets _reset>;

If you look @ v2 of the reset framework patchset your phandle should be

resets = <_resets _reset>;

If you call the device_reset phandle you will reset the SoC.


> + reset-names = "reset";

This needs to be more descriptive.

>   };
>  
>   sata: sata@4a141100 {


-- 
--
Dan Murphy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node

2014-05-06 Thread Kishon Vijay Abraham I
Added *resets* and *reset-names* properies for PCIe dt node.
The documention for this node can be found @ ../bindings/pci/ti-pci.txt.

Cc: Dan Murphy 
Signed-off-by: Kishon Vijay Abraham I 
---
 arch/arm/boot/dts/dra7.dtsi |2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 20b1a09..7bc0555 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1031,6 +1031,8 @@
ti,hwmods = "pcie1";
phys = <_phy>;
phy-names = "pcie-phy";
+   resets = <_resets _reset>;
+   reset-names = "reset";
};
 
sata: sata@4a141100 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node

2014-05-06 Thread Kishon Vijay Abraham I
Added *resets* and *reset-names* properies for PCIe dt node.
The documention for this node can be found @ ../bindings/pci/ti-pci.txt.

Cc: Dan Murphy dmur...@ti.com
Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
---
 arch/arm/boot/dts/dra7.dtsi |2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index 20b1a09..7bc0555 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -1031,6 +1031,8 @@
ti,hwmods = pcie1;
phys = pcie1_phy;
phy-names = pcie-phy;
+   resets = prm_resets device_reset;
+   reset-names = reset;
};
 
sata: sata@4a141100 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node

2014-05-06 Thread Dan Murphy
On 05/06/2014 08:34 AM, Kishon Vijay Abraham I wrote:
 Added *resets* and *reset-names* properies for PCIe dt node.
 The documention for this node can be found @ ../bindings/pci/ti-pci.txt.

 Cc: Dan Murphy dmur...@ti.com
 Signed-off-by: Kishon Vijay Abraham I kis...@ti.com
 ---
  arch/arm/boot/dts/dra7.dtsi |2 ++
  1 file changed, 2 insertions(+)

 diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
 index 20b1a09..7bc0555 100644
 --- a/arch/arm/boot/dts/dra7.dtsi
 +++ b/arch/arm/boot/dts/dra7.dtsi
 @@ -1031,6 +1031,8 @@
   ti,hwmods = pcie1;
   phys = pcie1_phy;
   phy-names = pcie-phy;
 + resets = prm_resets device_reset;

If you look @ v2 of the reset framework patchset your phandle should be

resets = prm_resets pcie1_reset;

If you call the device_reset phandle you will reset the SoC.


 + reset-names = reset;

This needs to be more descriptive.

   };
  
   sata: sata@4a141100 {


-- 
--
Dan Murphy

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/