Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-13 Thread Tom Rini
On Mon, Oct 13, 2014 at 08:48:39AM +0200, Jeroen Hofstee wrote: > Hello Simon, > > On 13-10-14 07:14, Simon Glass wrote: > >Hi Jeroen, > > > >On 12 October 2014 10:13, Jeroen Hofstee wrote: > > > >>Hello Hans, > >> > >>On 12-10-14 12:25, Hans de Goede wrote: > >> > >>>Hi, > >>> > >>>This one

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-13 Thread Jeroen Hofstee
Hello Simon, On 13-10-14 07:14, Simon Glass wrote: Hi Jeroen, On 12 October 2014 10:13, Jeroen Hofstee wrote: Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace an innocent warning

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-13 Thread Jeroen Hofstee
Hello Simon, On 13-10-14 07:14, Simon Glass wrote: Hi Jeroen, On 12 October 2014 10:13, Jeroen Hofstee jer...@myspectrum.nl wrote: Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-13 Thread Tom Rini
On Mon, Oct 13, 2014 at 08:48:39AM +0200, Jeroen Hofstee wrote: Hello Simon, On 13-10-14 07:14, Simon Glass wrote: Hi Jeroen, On 12 October 2014 10:13, Jeroen Hofstee jer...@myspectrum.nl wrote: Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Jeroen Hofstee
Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace an innocent warning (_might_ be) with bad code, without any comment it is just because gcc failed to recognize it is fine. Nor did you

Re: [U-Boot] [PATCH resend] kconfig: Fix compiler warning in menu.c

2014-10-12 Thread Jeroen Hofstee
Hello Hans, On 12-10-14 12:25, Hans de Goede wrote: Hi, This one seems to have fallen through the cracks. Regards, Hans (for U-boot) nope, you replace an innocent warning (_might_ be) with bad code, without any comment it is just because gcc failed to recognize it is fine. Nor did you