Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-24 Thread Borislav Petkov
On Tue, Nov 24, 2015 at 03:51:21PM +, Luck, Tony wrote: > >> Ok ... applied those two on top of my "UNTESTED" patch and injected an > >> error to force a UCNA log. > > > > Ok, what error type is that in EINJ nomenclature? I had only > > > >

RE: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-24 Thread Luck, Tony
>> Ok ... applied those two on top of my "UNTESTED" patch and injected an error >> to force a UCNA log. > > Ok, what error type is that in EINJ nomenclature? I had only > > /sys/kernel/debug/apei/einj/available_error_type:0x0002 Processor > Uncorrectable non-fatal >

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-24 Thread Borislav Petkov
On Tue, Nov 24, 2015 at 03:51:21PM +, Luck, Tony wrote: > >> Ok ... applied those two on top of my "UNTESTED" patch and injected an > >> error to force a UCNA log. > > > > Ok, what error type is that in EINJ nomenclature? I had only > > > >

RE: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-24 Thread Luck, Tony
>> Ok ... applied those two on top of my "UNTESTED" patch and injected an error >> to force a UCNA log. > > Ok, what error type is that in EINJ nomenclature? I had only > > /sys/kernel/debug/apei/einj/available_error_type:0x0002 Processor > Uncorrectable non-fatal >

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-23 Thread Borislav Petkov
On Tue, Nov 24, 2015 at 12:19:18AM +, Luck, Tony wrote: > > Also, two more fixes I've done while injecting in a kvm guest I'm > > sending as a reply to this message. Will inject on a real box too. > > Ok ... applied those two on top of my "UNTESTED" patch and injected an error > to force a

RE: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-23 Thread Luck, Tony
> Also, two more fixes I've done while injecting in a kvm guest I'm > sending as a reply to this message. Will inject on a real box too. Ok ... applied those two on top of my "UNTESTED" patch and injected an error to force a UCNA log. Everything looked ok. Just one copy on the console and in

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-23 Thread Borislav Petkov
On Thu, Nov 19, 2015 at 09:39:20PM +0100, Borislav Petkov wrote: > On Thu, Nov 19, 2015 at 07:33:58PM +, Luck, Tony wrote: > > > Applied, thanks. > > > > Did you test it (note the "UNTESTED" in the subject!). My usual system for > > this is getting upgrades and being > > flaky at the

RE: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-23 Thread Luck, Tony
> Also, two more fixes I've done while injecting in a kvm guest I'm > sending as a reply to this message. Will inject on a real box too. Ok ... applied those two on top of my "UNTESTED" patch and injected an error to force a UCNA log. Everything looked ok. Just one copy on the console and in

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-23 Thread Borislav Petkov
On Tue, Nov 24, 2015 at 12:19:18AM +, Luck, Tony wrote: > > Also, two more fixes I've done while injecting in a kvm guest I'm > > sending as a reply to this message. Will inject on a real box too. > > Ok ... applied those two on top of my "UNTESTED" patch and injected an error > to force a

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-23 Thread Borislav Petkov
On Thu, Nov 19, 2015 at 09:39:20PM +0100, Borislav Petkov wrote: > On Thu, Nov 19, 2015 at 07:33:58PM +, Luck, Tony wrote: > > > Applied, thanks. > > > > Did you test it (note the "UNTESTED" in the subject!). My usual system for > > this is getting upgrades and being > > flaky at the

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-21 Thread Borislav Petkov
On Wed, Nov 11, 2015 at 02:01:51PM -0800, Tony Luck wrote: > We used to have a special ring buffer for deferred errors that > was used to mark problem pages. We replaced that with a genpool. > Then later converted mce_log() to also use the same genpool. As > a result we end up adding all deferred

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-21 Thread Borislav Petkov
On Wed, Nov 11, 2015 at 02:01:51PM -0800, Tony Luck wrote: > We used to have a special ring buffer for deferred errors that > was used to mark problem pages. We replaced that with a genpool. > Then later converted mce_log() to also use the same genpool. As > a result we end up adding all deferred

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-19 Thread Borislav Petkov
On Thu, Nov 19, 2015 at 07:33:58PM +, Luck, Tony wrote: > > Applied, thanks. > > Did you test it (note the "UNTESTED" in the subject!). My usual system for > this is getting upgrades and being > flaky at the moment. Bah, it builds, should be enough. Ship it. :-) Lemme get a box... --

RE: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-19 Thread Luck, Tony
> Applied, thanks. Did you test it (note the "UNTESTED" in the subject!). My usual system for this is getting upgrades and being flaky at the moment. > Btw, looking at that mce.usable_addr, it doesn't make a whole lotta > sense to me and we can use mce_usable_address() directly instead and use

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-19 Thread Borislav Petkov
On Wed, Nov 11, 2015 at 02:01:51PM -0800, Tony Luck wrote: > We used to have a special ring buffer for deferred errors that > was used to mark problem pages. We replaced that with a genpool. > Then later converted mce_log() to also use the same genpool. As > a result we end up adding all deferred

RE: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-19 Thread Luck, Tony
> Applied, thanks. Did you test it (note the "UNTESTED" in the subject!). My usual system for this is getting upgrades and being flaky at the moment. > Btw, looking at that mce.usable_addr, it doesn't make a whole lotta > sense to me and we can use mce_usable_address() directly instead and use

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-19 Thread Borislav Petkov
On Thu, Nov 19, 2015 at 07:33:58PM +, Luck, Tony wrote: > > Applied, thanks. > > Did you test it (note the "UNTESTED" in the subject!). My usual system for > this is getting upgrades and being > flaky at the moment. Bah, it builds, should be enough. Ship it. :-) Lemme get a box... --

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-19 Thread Borislav Petkov
On Wed, Nov 11, 2015 at 02:01:51PM -0800, Tony Luck wrote: > We used to have a special ring buffer for deferred errors that > was used to mark problem pages. We replaced that with a genpool. > Then later converted mce_log() to also use the same genpool. As > a result we end up adding all deferred

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-11 Thread Chen, Gong
On Wed, Nov 11, 2015 at 02:01:51PM -0800, Luck, Tony wrote: > Date: Wed, 11 Nov 2015 14:01:51 -0800 > From: Tony Luck > To: "Chen, Gong" > Cc: b...@alien8.de, linux-e...@vger.kernel.org, linux-kernel@vger.kernel.org > Subject: [UNTESTED PATCH] x86, mce: Avoid double

[UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-11 Thread Tony Luck
We used to have a special ring buffer for deferred errors that was used to mark problem pages. We replaced that with a genpool. Then later converted mce_log() to also use the same genpool. As a result we end up adding all deferred errors to the genpool twice. Rearrange this code. Make sure to set

Re: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-11 Thread Chen, Gong
rg > Subject: [UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors > into the genpool. > > We used to have a special ring buffer for deferred errors that > was used to mark problem pages. We replaced that with a genpool. > Then later converted mce_log() to also use

[UNTESTED PATCH] x86, mce: Avoid double entry of deferred errors into the genpool.

2015-11-11 Thread Tony Luck
We used to have a special ring buffer for deferred errors that was used to mark problem pages. We replaced that with a genpool. Then later converted mce_log() to also use the same genpool. As a result we end up adding all deferred errors to the genpool twice. Rearrange this code. Make sure to set