Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-09 Thread Chunfeng Yun
On Thu, 2020-07-09 at 09:40 +0300, Felipe Balbi wrote: > Chunfeng Yun writes: > > > Some pointers are dereferenced before successful checks. > > > > Reported-by: Markus Elfring > > Signed-off-by: Chunfeng Yun > > do you need a Fixes tag here? Perhaps a Cc stable too? It will not cause somes

Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-09 Thread Felipe Balbi
Hi, Chunfeng Yun writes: >> > @@ -373,8 +380,8 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, >> > struct usb_request *req) >> > */ >> > static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value) >> > { >> > - struct mtu3_ep *mep = to_mtu3_ep(ep); >> > - struct mtu3 *mtu =

Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-09 Thread Felipe Balbi
Chunfeng Yun writes: > Some pointers are dereferenced before successful checks. > > Reported-by: Markus Elfring > Signed-off-by: Chunfeng Yun do you need a Fixes tag here? Perhaps a Cc stable too? -- balbi signature.asc Description: PGP signature

Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-01 Thread Chunfeng Yun
On Wed, 2020-07-01 at 13:58 +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 30, 2020 at 03:42:22PM +0800, Chunfeng Yun wrote: > > Some pointers are dereferenced before successful checks. > > > > Reported-by: Markus Elfring > > Signed-off-by: Chunfeng Yun > > --- > > v2: nothing changed, but

Re: [V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-07-01 Thread Greg Kroah-Hartman
On Tue, Jun 30, 2020 at 03:42:22PM +0800, Chunfeng Yun wrote: > Some pointers are dereferenced before successful checks. > > Reported-by: Markus Elfring > Signed-off-by: Chunfeng Yun > --- > v2: nothing changed, but abandon another patch > --- > drivers/usb/mtu3/mtu3_gadget.c | 25

[V2 PATCH] usb: mtu3: fix NULL pointer dereference

2020-06-30 Thread Chunfeng Yun
Some pointers are dereferenced before successful checks. Reported-by: Markus Elfring Signed-off-by: Chunfeng Yun --- v2: nothing changed, but abandon another patch --- drivers/usb/mtu3/mtu3_gadget.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git