Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Jan Beulich
>>> On 09.04.14 at 17:38, wrote: > On 04/09/2014 11:01 AM, Jan Beulich wrote: > On 09.04.14 at 16:41, wrote: >>> The latter load however can easy fault; The arguments for %ds in >>> XSA-42/ CVE-2013-0228 applies to %{e,f,g}s as well. >> And it was only that latter operation that I pointed

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Boris Ostrovsky
On 04/09/2014 11:01 AM, Jan Beulich wrote: On 09.04.14 at 16:41, wrote: The latter load however can easy fault; The arguments for %ds in XSA-42/ CVE-2013-0228 applies to %{e,f,g}s as well. And it was only that latter operation that I pointed at. We don't seem to reference %fs after the pop

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Jan Beulich
>>> On 09.04.14 at 16:41, wrote: > The latter load however can easy fault; The arguments for %ds in > XSA-42/ CVE-2013-0228 applies to %{e,f,g}s as well. And it was only that latter operation that I pointed at. > Furthermore, I am a little concerned about the performance impact of > this. I

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Andrew Cooper
On 09/04/14 15:29, David Vrabel wrote: > On 09/04/14 15:21, Jan Beulich wrote: > On 09.04.14 at 16:06, wrote: >>> --- a/arch/x86/xen/xen-asm_32.S >>> +++ b/arch/x86/xen/xen-asm_32.S >>> @@ -88,7 +88,11 @@ ENTRY(xen_iret) >>> * avoid having to reload %fs >>> */ >>> #ifdef CONFIG_SMP

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread David Vrabel
On 09/04/14 15:21, Jan Beulich wrote: On 09.04.14 at 16:06, wrote: >> --- a/arch/x86/xen/xen-asm_32.S >> +++ b/arch/x86/xen/xen-asm_32.S >> @@ -88,7 +88,11 @@ ENTRY(xen_iret) >> * avoid having to reload %fs >> */ >> #ifdef CONFIG_SMP >> +pushw %fs >> +movl

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Jan Beulich
>>> On 09.04.14 at 16:06, wrote: > --- a/arch/x86/xen/xen-asm_32.S > +++ b/arch/x86/xen/xen-asm_32.S > @@ -88,7 +88,11 @@ ENTRY(xen_iret) >* avoid having to reload %fs >*/ > #ifdef CONFIG_SMP > + pushw %fs > + movl $(__KERNEL_PERCPU), %eax > + movl %eax, %fs >

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Jan Beulich
On 09.04.14 at 16:06, boris.ostrov...@oracle.com wrote: --- a/arch/x86/xen/xen-asm_32.S +++ b/arch/x86/xen/xen-asm_32.S @@ -88,7 +88,11 @@ ENTRY(xen_iret) * avoid having to reload %fs */ #ifdef CONFIG_SMP + pushw %fs + movl $(__KERNEL_PERCPU), %eax + movl %eax,

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread David Vrabel
On 09/04/14 15:21, Jan Beulich wrote: On 09.04.14 at 16:06, boris.ostrov...@oracle.com wrote: --- a/arch/x86/xen/xen-asm_32.S +++ b/arch/x86/xen/xen-asm_32.S @@ -88,7 +88,11 @@ ENTRY(xen_iret) * avoid having to reload %fs */ #ifdef CONFIG_SMP +pushw %fs +movl

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Andrew Cooper
On 09/04/14 15:29, David Vrabel wrote: On 09/04/14 15:21, Jan Beulich wrote: On 09.04.14 at 16:06, boris.ostrov...@oracle.com wrote: --- a/arch/x86/xen/xen-asm_32.S +++ b/arch/x86/xen/xen-asm_32.S @@ -88,7 +88,11 @@ ENTRY(xen_iret) * avoid having to reload %fs */ #ifdef

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Jan Beulich
On 09.04.14 at 16:41, andrew.coop...@citrix.com wrote: The latter load however can easy fault; The arguments for %ds in XSA-42/ CVE-2013-0228 applies to %{e,f,g}s as well. And it was only that latter operation that I pointed at. Furthermore, I am a little concerned about the performance

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Boris Ostrovsky
On 04/09/2014 11:01 AM, Jan Beulich wrote: On 09.04.14 at 16:41, andrew.coop...@citrix.com wrote: The latter load however can easy fault; The arguments for %ds in XSA-42/ CVE-2013-0228 applies to %{e,f,g}s as well. And it was only that latter operation that I pointed at. We don't seem to

Re: [Xen-devel] [PATCH] x86/xen: Fix 32-bit PV guests's usage of kernel_stack

2014-04-09 Thread Jan Beulich
On 09.04.14 at 17:38, boris.ostrov...@oracle.com wrote: On 04/09/2014 11:01 AM, Jan Beulich wrote: On 09.04.14 at 16:41, andrew.coop...@citrix.com wrote: The latter load however can easy fault; The arguments for %ds in XSA-42/ CVE-2013-0228 applies to %{e,f,g}s as well. And it was only that