Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init()

2016-06-29 Thread David Vrabel
On 27/06/16 08:24, Jan Beulich wrote: On 24.06.16 at 17:01, wrote: >> On 07/06/16 07:31, Jan Beulich wrote: >>> - drop unused function parameter of read_dev_bar() >>> - drop rom_init() (now identical to bar_init()) >>> - fold read_dev_bar() into its now single caller

Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init()

2016-06-29 Thread David Vrabel
On 27/06/16 08:24, Jan Beulich wrote: On 24.06.16 at 17:01, wrote: >> On 07/06/16 07:31, Jan Beulich wrote: >>> - drop unused function parameter of read_dev_bar() >>> - drop rom_init() (now identical to bar_init()) >>> - fold read_dev_bar() into its now single caller >>> - simplify

Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init()

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 17:01, wrote: > On 07/06/16 07:31, Jan Beulich wrote: >> - drop unused function parameter of read_dev_bar() >> - drop rom_init() (now identical to bar_init()) >> - fold read_dev_bar() into its now single caller >> - simplify determination of 64-bit

Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init()

2016-06-27 Thread Jan Beulich
>>> On 24.06.16 at 17:01, wrote: > On 07/06/16 07:31, Jan Beulich wrote: >> - drop unused function parameter of read_dev_bar() >> - drop rom_init() (now identical to bar_init()) >> - fold read_dev_bar() into its now single caller >> - simplify determination of 64-bit memory resource >> - use

Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init()

2016-06-24 Thread David Vrabel
On 07/06/16 07:31, Jan Beulich wrote: > - drop unused function parameter of read_dev_bar() > - drop rom_init() (now identical to bar_init()) > - fold read_dev_bar() into its now single caller > - simplify determination of 64-bit memory resource > - use const and unsigned Please split this in 5

Re: [Xen-devel] [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init()

2016-06-24 Thread David Vrabel
On 07/06/16 07:31, Jan Beulich wrote: > - drop unused function parameter of read_dev_bar() > - drop rom_init() (now identical to bar_init()) > - fold read_dev_bar() into its now single caller > - simplify determination of 64-bit memory resource > - use const and unsigned Please split this in 5