Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-02-03 Thread Zoltan Kiss
On 03/02/14 11:57, David Vrabel wrote: Hi, That's bad indeed. I think the best solution is to put those parts behind an #ifdef x86. The ones moved from x86/p2m.c to grant-table.c. David, Stefano, what do you think? I don't think we want (more) #ifdef CONFIG_X86 in grant-table.c and the arch-sp

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-02-03 Thread Konrad Rzeszutek Wilk
On Mon, Feb 03, 2014 at 10:57:28AM +, David Vrabel wrote: > On 02/02/14 18:52, Zoltan Kiss wrote: > > On 02/02/14 11:29, Julien Grall wrote: > >> Hello, > >> > >> This patch is breaking Linux compilation on ARM: > >> > >> drivers/xen/grant-table.c: In function ‘__gnttab_map_refs’: > >> drivers/

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-02-03 Thread Stefano Stabellini
On Mon, 3 Feb 2014, David Vrabel wrote: > On 02/02/14 18:52, Zoltan Kiss wrote: > > On 02/02/14 11:29, Julien Grall wrote: > >> Hello, > >> > >> This patch is breaking Linux compilation on ARM: > >> > >> drivers/xen/grant-table.c: In function ‘__gnttab_map_refs’: > >> drivers/xen/grant-table.c:989:

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-02-03 Thread David Vrabel
On 02/02/14 18:52, Zoltan Kiss wrote: > On 02/02/14 11:29, Julien Grall wrote: >> Hello, >> >> This patch is breaking Linux compilation on ARM: >> >> drivers/xen/grant-table.c: In function ‘__gnttab_map_refs’: >> drivers/xen/grant-table.c:989:3: error: implicit declaration of >> function ‘FOREIGN_F

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-02-02 Thread Zoltan Kiss
On 02/02/14 11:29, Julien Grall wrote: Hello, This patch is breaking Linux compilation on ARM: drivers/xen/grant-table.c: In function ‘__gnttab_map_refs’: drivers/xen/grant-table.c:989:3: error: implicit declaration of function ‘FOREIGN_FRAME’ [-Werror=implicit-function-declaration] if (un

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-02-02 Thread Julien Grall
On 23/01/14 23:34, Stefano Stabellini wrote: > On Thu, 23 Jan 2014, Zoltan Kiss wrote: >> The grant mapping API does m2p_override unnecessarily: only gntdev needs it, >> for blkback and future netback patches it just cause a lock contention, as >> those pages never go to userspace. Therefore this

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-01-24 Thread Stefano Stabellini
On Thu, 23 Jan 2014, Matt Wilson wrote: > On Thu, Jan 23, 2014 at 09:23:44PM +, Zoltan Kiss wrote: > > The grant mapping API does m2p_override unnecessarily: only gntdev needs it, > > for blkback and future netback patches it just cause a lock contention, as > > those pages never go to userspac

Re: [Xen-devel] [PATCH v6] xen/grant-table: Avoid m2p_override during mapping

2014-01-24 Thread David Vrabel
On 24/01/14 05:48, Matt Wilson wrote: > On Thu, Jan 23, 2014 at 09:23:44PM +, Zoltan Kiss wrote: >> The grant mapping API does m2p_override unnecessarily: only gntdev needs it, >> for blkback and future netback patches it just cause a lock contention, as >> those pages never go to userspace. Th