; Wright;
virtualization@lists.osdl.org; Ingo Molnar; [EMAIL PROTECTED]
Subject: Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc
console infrastructure for Xen console
On 16/3/07 11:41, "Andrew Morton" <[EMAIL PROTECTED]> wrote:
>> It's needed for writing data /after
On 16/3/07 11:41, "Andrew Morton" <[EMAIL PROTECTED]> wrote:
>> It's needed for writing data /after/ reading the consumer index that shows
>> you have space to write. Looking through xenbus_comms.c I think all the
>> barriers are correct except there is a spurious extra mb() in xb_read(),
>>
On Fri, 16 Mar 2007 10:31:49 + Keir Fraser <[EMAIL PROTECTED]> wrote:
> On 16/3/07 09:58, "Ingo Molnar" <[EMAIL PROTECTED]> wrote:
>
> >> These mb()'s are pretty standard for lock-free producer/consumer
> >> rings. Write descriptor /then/ write the updated producer. Read the
> >> producer
On 16/3/07 09:58, "Ingo Molnar" <[EMAIL PROTECTED]> wrote:
>> These mb()'s are pretty standard for lock-free producer/consumer
>> rings. Write descriptor /then/ write the updated producer. Read the
>> producer /then/ read any descriptors revealed by this new producer
>> value.
>
> then use
* Keir Fraser <[EMAIL PROTECTED]> wrote:
> On 16/3/07 08:54, "Ingo Molnar" <[EMAIL PROTECTED]> wrote:
>
> >> + prod = intf->in_prod;
> >> + mb();
> >> + BUG_ON((prod - cons) > sizeof(intf->in));
> >
> > such mb()'s are typically a sign of "i have no clear idea what SMP
> > serialization rules
* Keir Fraser [EMAIL PROTECTED] wrote:
On 16/3/07 08:54, Ingo Molnar [EMAIL PROTECTED] wrote:
+ prod = intf-in_prod;
+ mb();
+ BUG_ON((prod - cons) sizeof(intf-in));
such mb()'s are typically a sign of i have no clear idea what SMP
serialization rules apply here, but something
On 16/3/07 09:58, Ingo Molnar [EMAIL PROTECTED] wrote:
These mb()'s are pretty standard for lock-free producer/consumer
rings. Write descriptor /then/ write the updated producer. Read the
producer /then/ read any descriptors revealed by this new producer
value.
then use rmb()/wmb(). Rarely
On Fri, 16 Mar 2007 10:31:49 + Keir Fraser [EMAIL PROTECTED] wrote:
On 16/3/07 09:58, Ingo Molnar [EMAIL PROTECTED] wrote:
These mb()'s are pretty standard for lock-free producer/consumer
rings. Write descriptor /then/ write the updated producer. Read the
producer /then/ read any
On 16/3/07 11:41, Andrew Morton [EMAIL PROTECTED] wrote:
It's needed for writing data /after/ reading the consumer index that shows
you have space to write. Looking through xenbus_comms.c I think all the
barriers are correct except there is a spurious extra mb() in xb_read(),
where there is a
; Wright;
virtualization@lists.osdl.org; Ingo Molnar; [EMAIL PROTECTED]
Subject: Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc
console infrastructure for Xen console
On 16/3/07 11:41, Andrew Morton [EMAIL PROTECTED] wrote:
It's needed for writing data /after/ reading the consumer index
10 matches
Mail list logo
