On Thu, 31 Aug 2017 12:37:16 +0200,
Mark Brown wrote:
>
> On Thu, Aug 31, 2017 at 12:23:14PM +0200, Takashi Iwai wrote:
>
> > Ah, wait, now I see your point. It was introduced by the very recent
> > patch through Mark's asoc tree (since it was wrongly labeled as "ASoC"
> > while it isn't).
On Thu, 31 Aug 2017 12:37:16 +0200,
Mark Brown wrote:
>
> On Thu, Aug 31, 2017 at 12:23:14PM +0200, Takashi Iwai wrote:
>
> > Ah, wait, now I see your point. It was introduced by the very recent
> > patch through Mark's asoc tree (since it was wrongly labeled as "ASoC"
> > while it isn't).
On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote:
> This is again a typical problem by such a trivial fix patch: the code
> looks as if it were trivial and correct, buried in a patch series that
> easily leads to the oversight by the maintainer's review.
Right, plus the amount of
On Thu, Aug 31, 2017 at 12:31:33PM +0200, Takashi Iwai wrote:
> This is again a typical problem by such a trivial fix patch: the code
> looks as if it were trivial and correct, buried in a patch series that
> easily leads to the oversight by the maintainer's review.
Right, plus the amount of
On Thu, Aug 31, 2017 at 12:23:14PM +0200, Takashi Iwai wrote:
> Ah, wait, now I see your point. It was introduced by the very recent
> patch through Mark's asoc tree (since it was wrongly labeled as "ASoC"
> while it isn't). That patch looks indeed fishy. The change in
> atmel_ac97c_resume()
On Thu, Aug 31, 2017 at 12:23:14PM +0200, Takashi Iwai wrote:
> Ah, wait, now I see your point. It was introduced by the very recent
> patch through Mark's asoc tree (since it was wrongly labeled as "ASoC"
> while it isn't). That patch looks indeed fishy. The change in
> atmel_ac97c_resume()
On Thu, 31 Aug 2017 12:19:03 +0200,
Mark Brown wrote:
>
> On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
>
> > And here is the fallout of the stupid, brainless "fixing" of issues
> > reported by static analysis tools.
>
> > This clk_prepare_enable will never fail. If it was
On Thu, 31 Aug 2017 12:19:03 +0200,
Mark Brown wrote:
>
> On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
>
> > And here is the fallout of the stupid, brainless "fixing" of issues
> > reported by static analysis tools.
>
> > This clk_prepare_enable will never fail. If it was
On Thu, 31 Aug 2017 12:13:00 +0200,
Takashi Iwai wrote:
>
> On Thu, 31 Aug 2017 11:56:16 +0200,
> Alexandre Belloni wrote:
> >
> > On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42
On Thu, 31 Aug 2017 12:13:00 +0200,
Takashi Iwai wrote:
>
> On Thu, 31 Aug 2017 11:56:16 +0200,
> Alexandre Belloni wrote:
> >
> > On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42
On 31/08/2017 at 12:13:00 +0200, Takashi Iwai wrote:
> On Thu, 31 Aug 2017 11:56:16 +0200,
> Alexandre Belloni wrote:
> >
> > On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42 +0200,
On 31/08/2017 at 12:13:00 +0200, Takashi Iwai wrote:
> On Thu, 31 Aug 2017 11:56:16 +0200,
> Alexandre Belloni wrote:
> >
> > On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
> > >
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42 +0200,
On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
> And here is the fallout of the stupid, brainless "fixing" of issues
> reported by static analysis tools.
> This clk_prepare_enable will never fail. If it was going to fail, the
> platform would never boot to a point were it is
On Thu, Aug 31, 2017 at 10:10:21AM +0200, Alexandre Belloni wrote:
> And here is the fallout of the stupid, brainless "fixing" of issues
> reported by static analysis tools.
> This clk_prepare_enable will never fail. If it was going to fail, the
> platform would never boot to a point were it is
On Thu, 31 Aug 2017 11:56:16 +0200,
Alexandre Belloni wrote:
>
> On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> >
> > > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > > If 'clk_prepare_enable()' fails, we must
On Thu, 31 Aug 2017 11:56:16 +0200,
Alexandre Belloni wrote:
>
> On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> >
> > > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > > If 'clk_prepare_enable()' fails, we must
On 31/08/2017 at 12:38:17 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-31 at 11:35 +0200, Alexandre Belloni wrote:
> > On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> > > On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> > > >
> > > > On Thu, 31 Aug 2017, Alexandre Belloni
On 31/08/2017 at 12:38:17 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-31 at 11:35 +0200, Alexandre Belloni wrote:
> > On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> > > On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> > > >
> > > > On Thu, 31 Aug 2017, Alexandre Belloni
On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
>
>
> On Thu, 31 Aug 2017, Alexandre Belloni wrote:
>
> > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > If 'clk_prepare_enable()' fails, we must release some resources before
> > > returning. Add a new label in the existing
On 31/08/2017 at 10:23:19 +0200, Julia Lawall wrote:
>
>
> On Thu, 31 Aug 2017, Alexandre Belloni wrote:
>
> > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > If 'clk_prepare_enable()' fails, we must release some resources before
> > > returning. Add a new label in the existing
On Thu, 2017-08-31 at 11:35 +0200, Alexandre Belloni wrote:
> On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42 +0200, Christophe
On Thu, 2017-08-31 at 11:35 +0200, Alexandre Belloni wrote:
> On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> > On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> > >
> > > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> > >
> > > > On 31/08/2017 at 06:40:42 +0200, Christophe
On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> >
> > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> >
> > > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > > If 'clk_prepare_enable()' fails, we must release
On 31/08/2017 at 12:04:03 +0300, Andy Shevchenko wrote:
> On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
> >
> > On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> >
> > > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > > If 'clk_prepare_enable()' fails, we must release
On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
>
> On Thu, 31 Aug 2017, Alexandre Belloni wrote:
>
> > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > If 'clk_prepare_enable()' fails, we must release some resources
> > > before
> > > returning. Add a new label in the
On Thu, 2017-08-31 at 10:23 +0200, Julia Lawall wrote:
>
> On Thu, 31 Aug 2017, Alexandre Belloni wrote:
>
> > On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > > If 'clk_prepare_enable()' fails, we must release some resources
> > > before
> > > returning. Add a new label in the
On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > If 'clk_prepare_enable()' fails, we must release some resources before
> > returning. Add a new label in the existing error handling path and 'goto'
> > there.
> >
> > Fixes:
On Thu, 31 Aug 2017, Alexandre Belloni wrote:
> On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> > If 'clk_prepare_enable()' fails, we must release some resources before
> > returning. Add a new label in the existing error handling path and 'goto'
> > there.
> >
> > Fixes:
On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> If 'clk_prepare_enable()' fails, we must release some resources before
> returning. Add a new label in the existing error handling path and 'goto'
> there.
>
> Fixes: 260ea95cc027 ("ASoC: atmel: ac97c: Handle return value of
>
On 31/08/2017 at 06:40:42 +0200, Christophe JAILLET wrote:
> If 'clk_prepare_enable()' fails, we must release some resources before
> returning. Add a new label in the existing error handling path and 'goto'
> there.
>
> Fixes: 260ea95cc027 ("ASoC: atmel: ac97c: Handle return value of
>
30 matches
Mail list logo
