Re: [alsa-devel] [PATCH v3 00/30] Update cros_ec_commands.h

2019-05-21 Thread Lee Jones
On Tue, 21 May 2019, Fabien Lahoudere wrote:

> Le jeudi 09 mai 2019 à 14:13 -0700, Gwendal Grignou a écrit :
> > The interface between CrosEC embedded controller and the host,
> > described by cros_ec_commands.h, as diverged from what the embedded
> > controller really support.
> > 
> > The source of thruth is at
> > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
> > 
> > That include file is converted to remove ACPI and Embedded only code.
> 
> Hi, 
> 
> I reviewed patches of the series and they looks good to me.
> 
> Reviewed-by: Fabien Lahoudere 

Thanks Fabien.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


Re: [alsa-devel] [PATCH v3 00/30] Update cros_ec_commands.h

2019-05-21 Thread Fabien Lahoudere
Le jeudi 09 mai 2019 à 14:13 -0700, Gwendal Grignou a écrit :
> The interface between CrosEC embedded controller and the host,
> described by cros_ec_commands.h, as diverged from what the embedded
> controller really support.
> 
> The source of thruth is at
> https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h
> 
> That include file is converted to remove ACPI and Embedded only code.

Hi, 

I reviewed patches of the series and they looks good to me.

Reviewed-by: Fabien Lahoudere