Re: [checkpatch] - Confusion

2013-06-11 Thread Joe Perches
On Tue, 2013-06-11 at 21:15 -0700, Joe Perches wrote: > > typedef struct ctl_table ctl_table; (include/linux/sysctl.h) > > is not correctly picked up by checkpatch. > > checkpatch isn't a c compiler. > It assumes any _t is a typedef. > > > So, I assume this actually is a false positive. >

Re: [checkpatch] - Confusion

2013-06-11 Thread Joe Perches
ernel@vger.kernel.org" ; > > >"linux...@kvack.org" > > >Sent: Sunday, 9 June 2013 10:58 PM > > >Subject: Re: [checkpatch] - Confusion > > > > > > > > >On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR > > >wrote: >

Re: [checkpatch] - Confusion

2013-06-11 Thread Sören Brinkmann
Hi Pintu, On Mon, Jun 10, 2013 at 11:49:00AM -0700, PINTU KUMAR wrote: > > > > From: anish singh > >To: PINTU KUMAR > >Cc: "linux-kernel@vger.kernel.org" ; > >"linux...@kvack.org" > >Sent: Sunday, 9 Jun

Re: [checkpatch] - Confusion

2013-06-11 Thread Sören Brinkmann
...@kvack.org Sent: Sunday, 9 June 2013 10:58 PM Subject: Re: [checkpatch] - Confusion On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR pintu_agar...@yahoo.com wrote: Hi, I wanted to submit my first patch. But I have some confusion about the /scripts/checkpatch.pl errors. After correcting

Re: [checkpatch] - Confusion

2013-06-11 Thread Joe Perches
linux-kernel@vger.kernel.org; linux...@kvack.org linux...@kvack.org Sent: Sunday, 9 June 2013 10:58 PM Subject: Re: [checkpatch] - Confusion On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR pintu_agar...@yahoo.com wrote: Hi, I wanted to submit my first patch. But I have

Re: [checkpatch] - Confusion

2013-06-11 Thread Joe Perches
On Tue, 2013-06-11 at 21:15 -0700, Joe Perches wrote: typedef struct ctl_table ctl_table; (include/linux/sysctl.h) is not correctly picked up by checkpatch. checkpatch isn't a c compiler. It assumes any foo_t is a typedef. So, I assume this actually is a false positive. Yup.

Re: [checkpatch] - Confusion

2013-06-10 Thread PINTU KUMAR
> > From: anish singh >To: PINTU KUMAR >Cc: "linux-kernel@vger.kernel.org" ; >"linux...@kvack.org" >Sent: Sunday, 9 June 2013 10:58 PM >Subject: Re: [checkpatch] - Confusion > > >On Mon, Jun 10, 2013 at 1

Re: [checkpatch] - Confusion

2013-06-10 Thread PINTU KUMAR
From: anish singh anish198519851...@gmail.com To: PINTU KUMAR pintu_agar...@yahoo.com Cc: linux-kernel@vger.kernel.org linux-kernel@vger.kernel.org; linux...@kvack.org linux...@kvack.org Sent: Sunday, 9 June 2013 10:58 PM Subject: Re: [checkpatch] - Confusion

Re: [checkpatch] - Confusion

2013-06-09 Thread anish singh
On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR wrote: > Hi, > > I wanted to submit my first patch. > But I have some confusion about the /scripts/checkpatch.pl errors. > > After correcting some checkpatch errors, when I run checkpatch.pl, it showed > me 0 errors. > But when I create patches are

[checkpatch] - Confusion

2013-06-09 Thread PINTU KUMAR
Hi, I wanted to submit my first patch. But I have some confusion about the /scripts/checkpatch.pl errors. After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors. But when I create patches are git format-patch, it is showing me 1 error. If I fix error in patch,

[checkpatch] - Confusion

2013-06-09 Thread PINTU KUMAR
Hi, I wanted to submit my first patch. But I have some confusion about the /scripts/checkpatch.pl errors. After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors. But when I create patches are git format-patch, it is showing me 1 error. If I fix error in patch,

Re: [checkpatch] - Confusion

2013-06-09 Thread anish singh
On Mon, Jun 10, 2013 at 11:21 AM, PINTU KUMAR pintu_agar...@yahoo.com wrote: Hi, I wanted to submit my first patch. But I have some confusion about the /scripts/checkpatch.pl errors. After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors. But when I