Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 23:49, Mikulas Patocka wrote: > > > On Thu, 3 Dec 2015, Baolin Wang wrote: > >> On 3 December 2015 at 10:56, Baolin Wang wrote: >> > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: >> >> On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >> >>> These are

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 23:47, Mikulas Patocka wrote: > > > On Thu, 3 Dec 2015, Baolin Wang wrote: > >> On 3 December 2015 at 03:56, Alasdair G Kergon wrote: >> > On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >> >> These are the benchmarks for request based dm-crypt. Please check

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Mikulas Patocka
On Thu, 3 Dec 2015, Baolin Wang wrote: > On 3 December 2015 at 10:56, Baolin Wang wrote: > > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: > >> On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > >>> These are the benchmarks for request based dm-crypt. Please check it. > >>

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Mikulas Patocka
On Thu, 3 Dec 2015, Baolin Wang wrote: > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: > > On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > >> These are the benchmarks for request based dm-crypt. Please check it. > > > > Now please put request-based dm-crypt completely to

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 19:07, Zdenek Kabelac wrote: > Dne 3.12.2015 v 11:36 Baolin Wang napsal(a): > >> On 3 December 2015 at 10:56, Baolin Wang wrote: >>> >>> On 3 December 2015 at 03:56, Alasdair G Kergon wrote: On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > >

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Zdenek Kabelac
Dne 3.12.2015 v 11:36 Baolin Wang napsal(a): On 3 December 2015 at 10:56, Baolin Wang wrote: On 3 December 2015 at 03:56, Alasdair G Kergon wrote: On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: These are the benchmarks for request based dm-crypt. Please check it. Now please

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 10:56, Baolin Wang wrote: > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: >> On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >>> These are the benchmarks for request based dm-crypt. Please check it. >> >> Now please put request-based dm-crypt completely

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 23:49, Mikulas Patocka wrote: > > > On Thu, 3 Dec 2015, Baolin Wang wrote: > >> On 3 December 2015 at 10:56, Baolin Wang wrote: >> > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: >> >> On Wed, Dec 02,

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 23:47, Mikulas Patocka wrote: > > > On Thu, 3 Dec 2015, Baolin Wang wrote: > >> On 3 December 2015 at 03:56, Alasdair G Kergon wrote: >> > On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >> >> These are the benchmarks for

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Zdenek Kabelac
Dne 3.12.2015 v 11:36 Baolin Wang napsal(a): On 3 December 2015 at 10:56, Baolin Wang wrote: On 3 December 2015 at 03:56, Alasdair G Kergon wrote: On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: These are the benchmarks for request based

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 19:07, Zdenek Kabelac wrote: > Dne 3.12.2015 v 11:36 Baolin Wang napsal(a): > >> On 3 December 2015 at 10:56, Baolin Wang wrote: >>> >>> On 3 December 2015 at 03:56, Alasdair G Kergon wrote: On Wed,

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Baolin Wang
On 3 December 2015 at 10:56, Baolin Wang wrote: > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: >> On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >>> These are the benchmarks for request based dm-crypt. Please check it. >> >> Now

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Mikulas Patocka
On Thu, 3 Dec 2015, Baolin Wang wrote: > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: > > On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > >> These are the benchmarks for request based dm-crypt. Please check it. > > > > Now please put request-based

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-03 Thread Mikulas Patocka
On Thu, 3 Dec 2015, Baolin Wang wrote: > On 3 December 2015 at 10:56, Baolin Wang wrote: > > On 3 December 2015 at 03:56, Alasdair G Kergon wrote: > >> On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > >>> These are the benchmarks for

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-02 Thread Baolin Wang
On 3 December 2015 at 03:56, Alasdair G Kergon wrote: > On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >> These are the benchmarks for request based dm-crypt. Please check it. > > Now please put request-based dm-crypt completely to one side and focus > just on the existing bio-based

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-02 Thread Alasdair G Kergon
On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > These are the benchmarks for request based dm-crypt. Please check it. Now please put request-based dm-crypt completely to one side and focus just on the existing bio-based code. Why is it slower and what can be adjusted to improve

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-02 Thread Alasdair G Kergon
On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: > These are the benchmarks for request based dm-crypt. Please check it. Now please put request-based dm-crypt completely to one side and focus just on the existing bio-based code. Why is it slower and what can be adjusted to improve

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-12-02 Thread Baolin Wang
On 3 December 2015 at 03:56, Alasdair G Kergon wrote: > On Wed, Dec 02, 2015 at 08:46:54PM +0800, Baolin Wang wrote: >> These are the benchmarks for request based dm-crypt. Please check it. > > Now please put request-based dm-crypt completely to one side and focus > just on the

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Christoph Hellwig
On Thu, Nov 12, 2015 at 10:36:34AM +0800, Baolin Wang wrote: > That's right. But we'll not introduce the duality things, cause we > will remove the bio based things in dm-crypt if the request based > things are accepted. No, you will NOT remote the bio based path. That would break all kinds of

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Christoph Hellwig
On Wed, Nov 11, 2015 at 01:18:13PM -0500, Mike Snitzer wrote: > But I'm trying to keep an open mind... show me data that real hardware > _really_ benefits and we'll go from there. Again, it needs to be "OMG, > this is amazing!" level performance to warrant any further serious > consideration.

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Christoph Hellwig
On Thu, Nov 12, 2015 at 10:36:34AM +0800, Baolin Wang wrote: > That's right. But we'll not introduce the duality things, cause we > will remove the bio based things in dm-crypt if the request based > things are accepted. No, you will NOT remote the bio based path. That would break all kinds of

Re: [dm-devel] [PATCH 0/2] Introduce the request handling for dm-crypt

2015-11-12 Thread Christoph Hellwig
On Wed, Nov 11, 2015 at 01:18:13PM -0500, Mike Snitzer wrote: > But I'm trying to keep an open mind... show me data that real hardware > _really_ benefits and we'll go from there. Again, it needs to be "OMG, > this is amazing!" level performance to warrant any further serious > consideration.