Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message()

2016-09-30 Thread Dan Carpenter
On Thu, Sep 29, 2016 at 05:43:57PM +0200, SF Markus Elfring wrote: > > In what bizzaro world is the "current Linux coding style convention" > > Do you look at the evolution for a document like "CodingStyle"? > Again, I wrote the paragraph in CodingStyle. I just said that it's a good idea to thi

Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message()

2016-09-29 Thread SF Markus Elfring
> In what bizzaro world is the "current Linux coding style convention" Do you look at the evolution for a document like "CodingStyle"? >> - >> -error: >> +show_warning: >> DMWARN("unrecognised message received."); >> return -EINVAL; >> } > > "show_warning" is better than "error" I g

Re: [dm-devel] [PATCH 03/10] md/dm-crypt: Rename a jump label in crypt_message()

2016-09-29 Thread Theodore Ts'o
On Wed, Sep 28, 2016 at 05:40:14PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 28 Sep 2016 14:54:39 +0200 > > Adjust a jump label according to the current Linux coding style convention. In what bizzaro world is the "current Linux coding style convention" > - > -error: >