Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 04:35:02PM -0700, Tejun Heo wrote: > debug. Would it be difficult to convert dm drivers to collect size > requirements and use front-pad for all per-bio data? I can't give a quick answer because a single bio may require a variable number (depending on the bio content) of

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Tejun Heo
Hello, Alasdair. On Tue, Sep 11, 2012 at 12:09:17AM +0100, Alasdair G Kergon wrote: > On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: > > IIUC, Kent posted a patch which converts all of them to use front-pad > > The only patch I saw posted here only handles one of the easier cases so

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: > IIUC, Kent posted a patch which converts all of them to use front-pad The only patch I saw posted here only handles one of the easier cases so far. The others are a bit trickier and probably involve a decision about which way to change

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Kent Overstreet
On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: > Hello, > > On Mon, Sep 10, 2012 at 3:50 PM, Alasdair G Kergon wrote: > >> > Note that this doesn't do anything for allocation from other > >> > mempools. > > > > Note that dm has several cases of this, so this patch should not be

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Kent Overstreet
On Mon, Sep 10, 2012 at 11:50:57PM +0100, Alasdair G Kergon wrote: > On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote: > > On Mon, Sep 10, 2012 at 02:56:33PM -0700, Kent Overstreet wrote: > > > commit df7e63cbffa3065fcc4ba2b9a93418d7c7312243 > > > Author: Kent Overstreet > > > Date:

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Tejun Heo
Hello, On Mon, Sep 10, 2012 at 3:50 PM, Alasdair G Kergon wrote: >> > Note that this doesn't do anything for allocation from other mempools. > > Note that dm has several cases of this, so this patch should not be used with > dm yet. Mikulas is studying those cases to see whether anything

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote: > On Mon, Sep 10, 2012 at 02:56:33PM -0700, Kent Overstreet wrote: > > commit df7e63cbffa3065fcc4ba2b9a93418d7c7312243 > > Author: Kent Overstreet > > Date: Mon Sep 10 14:33:46 2012 -0700 > > > > block: Avoid deadlocks with bio

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote: On Mon, Sep 10, 2012 at 02:56:33PM -0700, Kent Overstreet wrote: commit df7e63cbffa3065fcc4ba2b9a93418d7c7312243 Author: Kent Overstreet koverstr...@google.com Date: Mon Sep 10 14:33:46 2012 -0700 block: Avoid deadlocks

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Tejun Heo
Hello, On Mon, Sep 10, 2012 at 3:50 PM, Alasdair G Kergon a...@redhat.com wrote: Note that this doesn't do anything for allocation from other mempools. Note that dm has several cases of this, so this patch should not be used with dm yet. Mikulas is studying those cases to see whether

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Kent Overstreet
On Mon, Sep 10, 2012 at 11:50:57PM +0100, Alasdair G Kergon wrote: On Mon, Sep 10, 2012 at 03:09:10PM -0700, Tejun Heo wrote: On Mon, Sep 10, 2012 at 02:56:33PM -0700, Kent Overstreet wrote: commit df7e63cbffa3065fcc4ba2b9a93418d7c7312243 Author: Kent Overstreet koverstr...@google.com

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Kent Overstreet
On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: Hello, On Mon, Sep 10, 2012 at 3:50 PM, Alasdair G Kergon a...@redhat.com wrote: Note that this doesn't do anything for allocation from other mempools. Note that dm has several cases of this, so this patch should not be

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: IIUC, Kent posted a patch which converts all of them to use front-pad The only patch I saw posted here only handles one of the easier cases so far. The others are a bit trickier and probably involve a decision about which way to change

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Tejun Heo
Hello, Alasdair. On Tue, Sep 11, 2012 at 12:09:17AM +0100, Alasdair G Kergon wrote: On Mon, Sep 10, 2012 at 04:01:01PM -0700, Tejun Heo wrote: IIUC, Kent posted a patch which converts all of them to use front-pad The only patch I saw posted here only handles one of the easier cases so far.

Re: [dm-devel] [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers

2012-09-10 Thread Alasdair G Kergon
On Mon, Sep 10, 2012 at 04:35:02PM -0700, Tejun Heo wrote: debug. Would it be difficult to convert dm drivers to collect size requirements and use front-pad for all per-bio data? I can't give a quick answer because a single bio may require a variable number (depending on the bio content) of