On Wed, Sep 12, 2012 at 03:39:18PM -0400, Martin K. Petersen wrote:
> > "Kent" == Kent Overstreet writes:
>
> Kent,
>
> Kent> To fix the bug first, I'd have to reorder struct bio_pair and then
> Kent> just delete two lines of code from bio_integrity_split(). But the
> Kent> reordering is
On Wed, Sep 12, 2012 at 03:39:18PM -0400, Martin K. Petersen wrote:
Kent == Kent Overstreet koverstr...@google.com writes:
Kent,
Kent To fix the bug first, I'd have to reorder struct bio_pair and then
Kent just delete two lines of code from bio_integrity_split(). But the
Kent reordering
> "Kent" == Kent Overstreet writes:
Kent,
Kent> To fix the bug first, I'd have to reorder struct bio_pair and then
Kent> just delete two lines of code from bio_integrity_split(). But the
Kent> reordering is unnecessary with the refactoring.
Well, a bug is a bug and the fix needs to go into
Kent == Kent Overstreet koverstr...@google.com writes:
Kent,
Kent To fix the bug first, I'd have to reorder struct bio_pair and then
Kent just delete two lines of code from bio_integrity_split(). But the
Kent reordering is unnecessary with the refactoring.
Well, a bug is a bug and the fix
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote:
> Also there seems to be too much happening in this patch. Please break
> it down in 2. First fix the bio integrity bug you mentioned then
> introduce your changes on top.
Oh, I forgot - the reason I squashed them into one patch is
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote:
> On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote:
> > This adds a pointer to the bvec array to struct bio_integrity_payload,
> > instead of the bvecs always being inline; then the bvecs are allocated
> > with
On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote:
> This adds a pointer to the bvec array to struct bio_integrity_payload,
> instead of the bvecs always being inline; then the bvecs are allocated
> with bvec_alloc_bs().
If you starting allocating bvec from same mempool for bio and
On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote:
This adds a pointer to the bvec array to struct bio_integrity_payload,
instead of the bvecs always being inline; then the bvecs are allocated
with bvec_alloc_bs().
If you starting allocating bvec from same mempool for bio and
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote:
On Mon, Sep 10, 2012 at 05:22:12PM -0700, Kent Overstreet wrote:
This adds a pointer to the bvec array to struct bio_integrity_payload,
instead of the bvecs always being inline; then the bvecs are allocated
with bvec_alloc_bs().
On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote:
Also there seems to be too much happening in this patch. Please break
it down in 2. First fix the bio integrity bug you mentioned then
introduce your changes on top.
Oh, I forgot - the reason I squashed them into one patch is fixing
10 matches
Mail list logo