Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-04 Thread Chao Yu
On 2016/11/4 1:57, Jaegeuk Kim wrote: > On Thu, Nov 03, 2016 at 05:50:34PM +0800, Chao Yu wrote: >> On 2016/11/3 1:23, Jaegeuk Kim wrote: >>> On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: Hi Jaegeuk, On 2016/10/21 10:28, Jaegeuk Kim wrote: > This patch replaces the

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-04 Thread Chao Yu
On 2016/11/4 1:57, Jaegeuk Kim wrote: > On Thu, Nov 03, 2016 at 05:50:34PM +0800, Chao Yu wrote: >> On 2016/11/3 1:23, Jaegeuk Kim wrote: >>> On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: Hi Jaegeuk, On 2016/10/21 10:28, Jaegeuk Kim wrote: > This patch replaces the

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-03 Thread Jaegeuk Kim
On Thu, Nov 03, 2016 at 05:50:34PM +0800, Chao Yu wrote: > On 2016/11/3 1:23, Jaegeuk Kim wrote: > > On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/10/21 10:28, Jaegeuk Kim wrote: > >>> This patch replaces the copied code with original generic function.

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-03 Thread Jaegeuk Kim
On Thu, Nov 03, 2016 at 05:50:34PM +0800, Chao Yu wrote: > On 2016/11/3 1:23, Jaegeuk Kim wrote: > > On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/10/21 10:28, Jaegeuk Kim wrote: > >>> This patch replaces the copied code with original generic function.

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-03 Thread Chao Yu
On 2016/11/3 1:23, Jaegeuk Kim wrote: > On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/10/21 10:28, Jaegeuk Kim wrote: >>> This patch replaces the copied code with original generic function. >> >> Will we plan to do further enhance inside

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-03 Thread Chao Yu
On 2016/11/3 1:23, Jaegeuk Kim wrote: > On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/10/21 10:28, Jaegeuk Kim wrote: >>> This patch replaces the copied code with original generic function. >> >> Will we plan to do further enhance inside

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-02 Thread Jaegeuk Kim
On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/10/21 10:28, Jaegeuk Kim wrote: > > This patch replaces the copied code with original generic function. > > Will we plan to do further enhance inside f2fs_set_page_dirty_nobuffers, if we > don't it's better revert

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-02 Thread Jaegeuk Kim
On Wed, Nov 02, 2016 at 03:34:32PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/10/21 10:28, Jaegeuk Kim wrote: > > This patch replaces the copied code with original generic function. > > Will we plan to do further enhance inside f2fs_set_page_dirty_nobuffers, if we > don't it's better revert

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-02 Thread Chao Yu
Hi Jaegeuk, On 2016/10/21 10:28, Jaegeuk Kim wrote: > This patch replaces the copied code with original generic function. Will we plan to do further enhance inside f2fs_set_page_dirty_nobuffers, if we don't it's better revert fe76b796fc5194cc3d57265002e3a748566d073f, as we don't need to wrap

Re: [f2fs-dev] [PATCH 2/3] f2fs: use __set_page_dirty_nobuffers directly

2016-11-02 Thread Chao Yu
Hi Jaegeuk, On 2016/10/21 10:28, Jaegeuk Kim wrote: > This patch replaces the copied code with original generic function. Will we plan to do further enhance inside f2fs_set_page_dirty_nobuffers, if we don't it's better revert fe76b796fc5194cc3d57265002e3a748566d073f, as we don't need to wrap