RE: [f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Chao Yu
Hi, > -Original Message- > From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] > Sent: Friday, December 06, 2013 12:12 PM > To: Chao Yu > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net; 谭姝 > Subject: Re: [f2

Re: [f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Jaegeuk Kim
Hi, Just in case, if you agreed the following comments, I'll fix those and merge the patch by myself. Thanks, 2013-12-05 (목), 17:15 +0800, Chao Yu: > As we know, some of our branch condition will rarely be true. So we could add > 'unlikely' to let compiler optimize these code, by this way we

[f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Chao Yu
As we know, some of our branch condition will rarely be true. So we could add 'unlikely' to let compiler optimize these code, by this way we could drop unneeded 'jump' assemble code to improve performance. change log: o add *unlikely* as many as possible across the whole source files at once

[f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Chao Yu
As we know, some of our branch condition will rarely be true. So we could add 'unlikely' to let compiler optimize these code, by this way we could drop unneeded 'jump' assemble code to improve performance. change log: o add *unlikely* as many as possible across the whole source files at once

Re: [f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Jaegeuk Kim
Hi, Just in case, if you agreed the following comments, I'll fix those and merge the patch by myself. Thanks, 2013-12-05 (목), 17:15 +0800, Chao Yu: As we know, some of our branch condition will rarely be true. So we could add 'unlikely' to let compiler optimize these code, by this way we could

RE: [f2fs-dev] [PATCH 2/5 V2] f2fs: add unlikely() macro for compiler optimization

2013-12-05 Thread Chao Yu
Hi, -Original Message- From: Jaegeuk Kim [mailto:jaegeuk@samsung.com] Sent: Friday, December 06, 2013 12:12 PM To: Chao Yu Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-f2fs-de...@lists.sourceforge.net; 谭姝 Subject: Re: [f2fs-dev] [PATCH 2/5 V2] f2fs