Re: [ipc] 5769cf63: LTP semget02 TFAILs
On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu wrote: > Hi Davidlohr, > > We noticed LTP test failures > > ltp.msgget02.1.TFAIL > ltp.semget02.2.TFAIL > ltp.semget02.3.TFAIL > > and the first bad commit is > > commit 5769cf6355d87f63906b3e51887eff7017c39217 > Author: Davidlohr Bueso > AuthorDate: Wed Jan 15 16:56:01 2014 +1100 > Commit: Stephen Rothwell > CommitDate: Wed Jan 15 16:56:01 2014 +1100 > > ipc: share ids rwsem when possible in ipcget_public > Thanks (a lot). I'll disable that patch for now. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ipc] 5769cf63: LTP semget02 TFAILs
[ Just adding Andrew to the cc list ] On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu wrote: > > Hi Davidlohr, > > We noticed LTP test failures > > ltp.msgget02.1.TFAIL > ltp.semget02.2.TFAIL > ltp.semget02.3.TFAIL > > and the first bad commit is > > commit 5769cf6355d87f63906b3e51887eff7017c39217 > Author: Davidlohr Bueso > AuthorDate: Wed Jan 15 16:56:01 2014 +1100 > Commit: Stephen Rothwell > CommitDate: Wed Jan 15 16:56:01 2014 +1100 > > ipc: share ids rwsem when possible in ipcget_public > > ... and rewrite the function. For scenarios where the key is found and > we end up just doing different routinary checks, we can downgrade the > ids->rwsem and share it among concurrent readers. These checks include > the following, which are all safe to share the lock: > > ops->more_checks() >> sem_more_checks(), shm_more_checks() > ipc_check_perms() >> ipcperms(),ops->associate() >> > [lsm]_[ipctype]_associate() > > Signed-off-by: Davidlohr Bueso > Cc: Aswin Chandramouleeswaran > Cc: Rik van Riel > Cc: Manfred Spraul > Signed-off-by: Andrew Morton > > ipc/util.c | 60 +--- > 1 file changed, 33 insertions(+), 27 deletions(-) > > Thanks, > Fengguang > -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpig_tWSdlcn.pgp Description: PGP signature
[ipc] 5769cf63: LTP semget02 TFAILs
Hi Davidlohr, We noticed LTP test failures ltp.msgget02.1.TFAIL ltp.semget02.2.TFAIL ltp.semget02.3.TFAIL and the first bad commit is commit 5769cf6355d87f63906b3e51887eff7017c39217 Author: Davidlohr Bueso AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell CommitDate: Wed Jan 15 16:56:01 2014 +1100 ipc: share ids rwsem when possible in ipcget_public ... and rewrite the function. For scenarios where the key is found and we end up just doing different routinary checks, we can downgrade the ids->rwsem and share it among concurrent readers. These checks include the following, which are all safe to share the lock: ops->more_checks() >> sem_more_checks(), shm_more_checks() ipc_check_perms() >> ipcperms(),ops->associate() >> [lsm]_[ipctype]_associate() Signed-off-by: Davidlohr Bueso Cc: Aswin Chandramouleeswaran Cc: Rik van Riel Cc: Manfred Spraul Signed-off-by: Andrew Morton ipc/util.c | 60 +--- 1 file changed, 33 insertions(+), 27 deletions(-) Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[ipc] 5769cf63: LTP semget02 TFAILs
Hi Davidlohr, We noticed LTP test failures ltp.msgget02.1.TFAIL ltp.semget02.2.TFAIL ltp.semget02.3.TFAIL and the first bad commit is commit 5769cf6355d87f63906b3e51887eff7017c39217 Author: Davidlohr Bueso davidl...@hp.com AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell s...@canb.auug.org.au CommitDate: Wed Jan 15 16:56:01 2014 +1100 ipc: share ids rwsem when possible in ipcget_public ... and rewrite the function. For scenarios where the key is found and we end up just doing different routinary checks, we can downgrade the ids-rwsem and share it among concurrent readers. These checks include the following, which are all safe to share the lock: ops-more_checks() sem_more_checks(), shm_more_checks() ipc_check_perms()ipcperms(),ops-associate() [lsm]_[ipctype]_associate() Signed-off-by: Davidlohr Bueso davidl...@hp.com Cc: Aswin Chandramouleeswaran as...@hp.com Cc: Rik van Riel r...@redhat.com Cc: Manfred Spraul manf...@colorfullife.com Signed-off-by: Andrew Morton a...@linux-foundation.org ipc/util.c | 60 +--- 1 file changed, 33 insertions(+), 27 deletions(-) Thanks, Fengguang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ipc] 5769cf63: LTP semget02 TFAILs
[ Just adding Andrew to the cc list ] On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu fengguang...@intel.com wrote: Hi Davidlohr, We noticed LTP test failures ltp.msgget02.1.TFAIL ltp.semget02.2.TFAIL ltp.semget02.3.TFAIL and the first bad commit is commit 5769cf6355d87f63906b3e51887eff7017c39217 Author: Davidlohr Bueso davidl...@hp.com AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell s...@canb.auug.org.au CommitDate: Wed Jan 15 16:56:01 2014 +1100 ipc: share ids rwsem when possible in ipcget_public ... and rewrite the function. For scenarios where the key is found and we end up just doing different routinary checks, we can downgrade the ids-rwsem and share it among concurrent readers. These checks include the following, which are all safe to share the lock: ops-more_checks() sem_more_checks(), shm_more_checks() ipc_check_perms()ipcperms(),ops-associate() [lsm]_[ipctype]_associate() Signed-off-by: Davidlohr Bueso davidl...@hp.com Cc: Aswin Chandramouleeswaran as...@hp.com Cc: Rik van Riel r...@redhat.com Cc: Manfred Spraul manf...@colorfullife.com Signed-off-by: Andrew Morton a...@linux-foundation.org ipc/util.c | 60 +--- 1 file changed, 33 insertions(+), 27 deletions(-) Thanks, Fengguang -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpig_tWSdlcn.pgp Description: PGP signature
Re: [ipc] 5769cf63: LTP semget02 TFAILs
On Fri, 17 Jan 2014 18:24:28 +0800 Fengguang Wu fengguang...@intel.com wrote: Hi Davidlohr, We noticed LTP test failures ltp.msgget02.1.TFAIL ltp.semget02.2.TFAIL ltp.semget02.3.TFAIL and the first bad commit is commit 5769cf6355d87f63906b3e51887eff7017c39217 Author: Davidlohr Bueso davidl...@hp.com AuthorDate: Wed Jan 15 16:56:01 2014 +1100 Commit: Stephen Rothwell s...@canb.auug.org.au CommitDate: Wed Jan 15 16:56:01 2014 +1100 ipc: share ids rwsem when possible in ipcget_public Thanks (a lot). I'll disable that patch for now. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
