Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2014-01-07 Thread Chen-Yu Tsai
Hi, On Thu, Jan 2, 2014 at 9:11 PM, srinivas kandagatla wrote: > Hi Chen, > > On 24/12/13 03:27, Chen-Yu Tsai wrote: >> Srinivas, >> >> Let's keep platform data as of_data, so SoC compatibles can pass >> hardware feature flags for cores that don't support auto-detection. > > I understand your

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2014-01-07 Thread Chen-Yu Tsai
Hi, On Thu, Jan 2, 2014 at 9:11 PM, srinivas kandagatla srinivas.kandaga...@st.com wrote: Hi Chen, On 24/12/13 03:27, Chen-Yu Tsai wrote: Srinivas, Let's keep platform data as of_data, so SoC compatibles can pass hardware feature flags for cores that don't support auto-detection. I

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2014-01-02 Thread srinivas kandagatla
Hi Chen, On 24/12/13 03:27, Chen-Yu Tsai wrote: > Srinivas, > > Let's keep platform data as of_data, so SoC compatibles can pass > hardware feature flags for cores that don't support auto-detection. I understand your concern here, But making platform_data as of_data would just open a wide door

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2014-01-02 Thread srinivas kandagatla
Hi Chen, On 24/12/13 03:27, Chen-Yu Tsai wrote: Srinivas, Let's keep platform data as of_data, so SoC compatibles can pass hardware feature flags for cores that don't support auto-detection. I understand your concern here, But making platform_data as of_data would just open a wide door for

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-23 Thread Chen-Yu Tsai
Hi, On Fri, Dec 13, 2013 at 6:38 PM, Maxime Ripard wrote: > On Thu, Dec 12, 2013 at 06:31:43PM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Thu, Dec 12, 2013 at 5:04 PM, Maxime Ripard >> wrote: >> > Hi, >> > >> > On Wed, Dec 11, 2013 at 02:45:08PM +, srinivas kandagatla wrote: >> >> >>> 1.

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-23 Thread Chen-Yu Tsai
Hi, On Fri, Dec 13, 2013 at 6:38 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Dec 12, 2013 at 06:31:43PM +0800, Chen-Yu Tsai wrote: Hi, On Thu, Dec 12, 2013 at 5:04 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Hi, On Wed, Dec 11, 2013 at 02:45:08PM

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-10 Thread Maxime Ripard
On Mon, Dec 09, 2013 at 08:04:21PM +0100, Hans de Goede wrote: > >>Now reading this has also made me take a closer look at wens' patch > >>for this. Wens, I see that you directly modify registers in the ccm > >>that is a big no-no instead you should add a helper function to > >>sunxi-clk.c and use

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-10 Thread Maxime Ripard
On Mon, Dec 09, 2013 at 08:04:21PM +0100, Hans de Goede wrote: Now reading this has also made me take a closer look at wens' patch for this. Wens, I see that you directly modify registers in the ccm that is a big no-no instead you should add a helper function to sunxi-clk.c and use that, see

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 06:56 PM, Chen-Yu Tsai wrote: Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede wrote: Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede wrote: > Hi, > > > On 12/09/2013 12:10 PM, srinivas kandagatla wrote: >> >> Hi Chen, >> Good to know that Allwinner uses gmac. >> >> On ST SoC, we have very similar requirements, before we merge any of >> these changes I think we need to come

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these changes I think we need to come up with common way to solve both Allwinner and ST SOCs use cases. I have already

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Mon, Dec 9, 2013 at 9:44 PM, Sergei Shtylyov wrote: > Hello. > > > On 09-12-2013 15:21, srinivas kandagatla wrote: > >>> +static int sun7i_gmac_init(struct platform_device *pdev) >>> +{ >>> + struct resource *res; >>> + struct device *dev = >dev; >>> + void __iomem *addr

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Mon, Dec 9, 2013 at 9:44 PM, Sergei Shtylyov sergei.shtyl...@cogentembedded.com wrote: Hello. On 09-12-2013 15:21, srinivas kandagatla wrote: +static int sun7i_gmac_init(struct platform_device *pdev) +{ + struct resource *res; + struct device *dev = pdev-dev; +

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these changes I think we need to come up with common way to solve both Allwinner and ST SOCs use cases. I have already

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Chen-Yu Tsai
Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we merge any of these changes I think we need to

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-09 Thread Hans de Goede
Hi, On 12/09/2013 06:56 PM, Chen-Yu Tsai wrote: Hi, On Tue, Dec 10, 2013 at 12:16 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 12/09/2013 12:10 PM, srinivas kandagatla wrote: Hi Chen, Good to know that Allwinner uses gmac. On ST SoC, we have very similar requirements, before we

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Emilio López
El 07/12/13 09:50, Tomasz Figa escribió: On Saturday 07 of December 2013 12:46:16 Maxime Ripard wrote: On Sat, Dec 07, 2013 at 12:12:26PM +0100, Tomasz Figa wrote: On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote: Chen-Yu, Mike, On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu

Re: [linux-sunxi] Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in Allwinner A20 SoC's

2013-12-07 Thread Emilio López
El 07/12/13 09:50, Tomasz Figa escribió: On Saturday 07 of December 2013 12:46:16 Maxime Ripard wrote: On Sat, Dec 07, 2013 at 12:12:26PM +0100, Tomasz Figa wrote: On Saturday 07 of December 2013 11:27:10 Maxime Ripard wrote: Chen-Yu, Mike, On Sat, Dec 07, 2013 at 01:29:37AM +0800, Chen-Yu