Re: [patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter Acked-by: Jeff Garzik -- To

[patch] [SCSI] mvsas: fix a && vs & bug

2012-08-16 Thread Dan Carpenter
The "1 << (slot_idx % 32)" condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter --- Static checker fix. Untested. Would apply to the -stable kernel. diff --git

[patch] [SCSI] mvsas: fix a vs bug

2012-08-16 Thread Dan Carpenter
The 1 (slot_idx % 32) condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- Static checker fix. Untested. Would apply to the -stable

Re: [patch] [SCSI] mvsas: fix a vs bug

2012-08-16 Thread Jeff Garzik
On 08/16/2012 07:04 AM, Dan Carpenter wrote: The 1 (slot_idx % 32) condition is always true. The intent was to test a bit field here using bitwise AND. We do the test correctly a few lines later in the do while loop. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Jeff