Re: [patch] agp: don't lock pages

2007-07-25 Thread Nick Piggin
On Thu, Jul 26, 2007 at 11:44:22AM +1000, Dave Airlie wrote: > > > >Yeah I had a bit of a look around, and it seems OK (but would > >appreciate an ack from someone who knows the code). > > > >These pages will never get seen by page reclaim, so we're OK > >there. There is a get_page before the SetPa

Re: [patch] agp: don't lock pages

2007-07-25 Thread Dave Airlie
On Thu, Jul 26, 2007 at 07:26:53AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2007-07-25 at 13:19 +0200, Nick Piggin wrote: > > Hi, > > > > Does this patch solve the X problem? Does anyone see anything wrong > > with it or know why agp was locking the pages? > > We need to do a little bit of

Re: [patch] agp: don't lock pages

2007-07-25 Thread Nick Piggin
[one more try] On Thu, Jul 26, 2007 at 02:41:14AM +0200, Nick Piggin wrote: > [forgot to cc Dave Jones...] > > > On Thu, Jul 26, 2007 at 07:26:53AM +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2007-07-25 at 13:19 +0200, Nick Piggin wrote: > > > Hi, > > > > > > Does this patch solve the X pr

Re: [patch] agp: don't lock pages

2007-07-25 Thread Nick Piggin
[forgot to cc Dave Jones...] On Thu, Jul 26, 2007 at 07:26:53AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2007-07-25 at 13:19 +0200, Nick Piggin wrote: > > Hi, > > > > Does this patch solve the X problem? Does anyone see anything wrong > > with it or know why agp was locking the pages? > >

Re: [patch] agp: don't lock pages

2007-07-25 Thread Benjamin Herrenschmidt
On Wed, 2007-07-25 at 13:19 +0200, Nick Piggin wrote: > Hi, > > Does this patch solve the X problem? Does anyone see anything wrong > with it or know why agp was locking the pages? We need to do a little bit of auditing here, but I suspect it will turn out all right. I think the reason it locked

Re: [patch] agp: don't lock pages

2007-07-25 Thread Bret Towe
On 7/25/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Hi, Does this patch solve the X problem? Does anyone see anything wrong with it or know why agp was locking the pages? Yeap the mac mini is happy again Thanks -- AGP should not need to lock pages. They are not protecting any race because the

[patch] agp: don't lock pages

2007-07-25 Thread Nick Piggin
Hi, Does this patch solve the X problem? Does anyone see anything wrong with it or know why agp was locking the pages? -- AGP should not need to lock pages. They are not protecting any race because there is no lock_page calls, only SetPageLocked. This is causing hangs with d00806b183152af6d24f46