> People, who do cleanups - I'm not talking about running lindent here -
> read through the code while they fix it up.
Please feel free to repeat my little experiment: give someone who sends
you a lot of checkpatch.pl only patches a simple task that actually
requires a little actual code change
On Saturday 16 February 2008 11:27:33 Pekka Enberg wrote:
> Hi,
>
> On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote:
> > People, who do cleanups - I'm not talking about running lindent here -
> > read through the code while they fix it up.
> >
> > Actually they find bugs that
On Saturday 16 February 2008 11:27:33 Pekka Enberg wrote:
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.
Actually they find bugs that way or at
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.
Please feel free to repeat my little experiment: give someone who sends
you a lot of checkpatch.pl only patches a simple task that actually
requires a little actual code change
On Sat, 16 Feb 2008, Andy Whitcroft wrote:
> On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
> > Hi,
> >
> > On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote:
> > > People, who do cleanups - I'm not talking about running lindent here -
> > > read through the code
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
> Hi,
>
> On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote:
> > People, who do cleanups - I'm not talking about running lindent here -
> > read through the code while they fix it up.
> >
> > Actually they find bugs
[Pekka Enberg - Sat, Feb 16, 2008 at 12:27:33PM +0200]
| Hi,
|
| On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote:
| > People, who do cleanups - I'm not talking about running lindent here -
| > read through the code while they fix it up.
| >
| > Actually they find bugs that way
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote:
> People, who do cleanups - I'm not talking about running lindent here -
> read through the code while they fix it up.
>
> Actually they find bugs that way or at least come up with useful
> questions about code which is not
On Fri, 15 Feb 2008, Andi Kleen wrote:
> > In the past few months we frequently mentioned checkpatch.pl --file to
> > arch/x86 newbies and it's been a great source of cleanup patches and it
> > has become an integral part of our workflow. Newbies should start with
> > small baby steps, with
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.
Actually they find bugs that way or at least come up with useful
questions about code which is not obvious
On Fri, 15 Feb 2008, Andi Kleen wrote:
In the past few months we frequently mentioned checkpatch.pl --file to
arch/x86 newbies and it's been a great source of cleanup patches and it
has become an integral part of our workflow. Newbies should start with
small baby steps, with trivial
[Pekka Enberg - Sat, Feb 16, 2008 at 12:27:33PM +0200]
| Hi,
|
| On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
| People, who do cleanups - I'm not talking about running lindent here -
| read through the code while they fix it up.
|
| Actually they find bugs that way or at
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.
Actually they find bugs that way or at
On Sat, 16 Feb 2008, Andy Whitcroft wrote:
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix
>
> In the past few months we frequently mentioned checkpatch.pl --file to
> arch/x86 newbies and it's been a great source of cleanup patches and it
> has become an integral part of our workflow. Newbies should start with
> small baby steps, with trivial patches, they should learn to write
Revert the incorrect, 6-line "WARNING" message that "checkpatch.pl
--file" started emitting since commit 13214adf738ab, which was merged
yesterday:
Andi Kleen (1):
Introduce a warning when --file mode is used
The message warns against sending "pure code style patches":
$
Revert the incorrect, 6-line WARNING message that checkpatch.pl
--file started emitting since commit 13214adf738ab, which was merged
yesterday:
Andi Kleen (1):
Introduce a warning when --file mode is used
The message warns against sending pure code style patches:
$
In the past few months we frequently mentioned checkpatch.pl --file to
arch/x86 newbies and it's been a great source of cleanup patches and it
has become an integral part of our workflow. Newbies should start with
small baby steps, with trivial patches, they should learn to write clean
18 matches
Mail list logo
