Re: [patch] drm/amdkfd: fix some range checks in address watch ioctl

2015-06-16 Thread Oded Gabbay
On Thu, Jun 11, 2015 at 6:19 PM, Dan Carpenter wrote: > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > index 96c904b..54a608a 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c > @@

Re: [patch] drm/amdkfd: fix some range checks in address watch ioctl

2015-06-16 Thread Oded Gabbay
On Thu, Jun 11, 2015 at 6:19 PM, Dan Carpenter dan.carpen...@oracle.com wrote: diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 96c904b..54a608a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++

Re: [patch] drm/amdkfd: fix some range checks in address watch ioctl

2015-06-14 Thread Oded Gabbay
On Thu, Jun 11, 2015 at 6:19 PM, Dan Carpenter wrote: > #include "kfd_dbgmgr.h" > +#include "../../radeon/cik_reg.h" > > static long kfd_ioctl(struct file *, unsigned int, unsigned long); We can't include radeon files in kfd_chardev.c, because amdkfd works with two device drivers - radeon and

Re: [patch] drm/amdkfd: fix some range checks in address watch ioctl

2015-06-14 Thread Oded Gabbay
On Thu, Jun 11, 2015 at 6:19 PM, Dan Carpenter dan.carpen...@oracle.com wrote: #include kfd_dbgmgr.h +#include ../../radeon/cik_reg.h static long kfd_ioctl(struct file *, unsigned int, unsigned long); We can't include radeon files in kfd_chardev.c, because amdkfd works with two device

[patch] drm/amdkfd: fix some range checks in address watch ioctl

2015-06-11 Thread Dan Carpenter
->buf_size_in_bytes must be large enough to hold ->num_watch_points and ->watch_mode so I have added a sizeof(int) * 2 to the minimum size. Also we have to subtract sizeof(*args) from the max args_idx limit so that it matches the allocation. Also I changed a > to >= for the last compare. I

[patch] drm/amdkfd: fix some range checks in address watch ioctl

2015-06-11 Thread Dan Carpenter
-buf_size_in_bytes must be large enough to hold -num_watch_points and -watch_mode so I have added a sizeof(int) * 2 to the minimum size. Also we have to subtract sizeof(*args) from the max args_idx limit so that it matches the allocation. Also I changed a to = for the last compare. I moved the