Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Joerg Roedel
On Wed, Mar 02, 2016 at 01:10:47PM +0300, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of > initcall') > Signed-off-by: Dan Carpenter

Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Joerg Roedel
On Wed, Mar 02, 2016 at 01:10:47PM +0300, Dan Carpenter wrote: > of_platform_device_create() returns NULL on error, it never returns > error pointers. > > Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of > initcall') > Signed-off-by: Dan Carpenter Applied, thanks.

Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Marek Szyprowski
Hello, On 2016-03-02 11:10, Dan Carpenter wrote: of_platform_device_create() returns NULL on error, it never returns error pointers. Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') Signed-off-by: Dan Carpenter Acked-by:

Re: [patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Marek Szyprowski
Hello, On 2016-03-02 11:10, Dan Carpenter wrote: of_platform_device_create() returns NULL on error, it never returns error pointers. Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') Signed-off-by: Dan Carpenter Acked-by: Marek Szyprowski diff

[patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Dan Carpenter
of_platform_device_create() returns NULL on error, it never returns error pointers. Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') Signed-off-by: Dan Carpenter diff --git a/drivers/iommu/exynos-iommu.c

[patch] iommu/exynos: checking for IS_ERR() instead of NULL

2016-03-02 Thread Dan Carpenter
of_platform_device_create() returns NULL on error, it never returns error pointers. Fixes: 8ed55c812fa8 ('iommu/exynos: Init from dt-specific callback instead of initcall') Signed-off-by: Dan Carpenter diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c index