Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-11 Thread Heiko Carstens
> My current version: > > From 97f115834b5ebef4f04e0f18aaa10f78f43733a0 Mon Sep 17 00:00:00 2001 > From: Al Viro <[EMAIL PROTECTED]> > Date: Sat, 10 Feb 2007 23:41:09 -0500 > Subject: [PATCH] sort the devres mess out > > Split the implementation-agnostic stuff in separate files. > Make sure that

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-11 Thread Jeff Garzik
Al Viro wrote: Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/arm/Kconfig |5 + arch/cris/Kconfig |3 + arch/h8300/Kconfig |3 + arch/h8300/kernel/Makefile |4 +- arch/m32r/Kconfig |3 + arch/m68k/Kconfig |3 + arch/m68k/k

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-11 Thread Al Viro
On Sun, Feb 11, 2007 at 07:10:47AM +, Christoph Hellwig wrote: > On Sun, Feb 11, 2007 at 06:34:31AM +, Al Viro wrote: > > +config NO_IOPORT > > + bool > > + default n > > please make this IOPORT. config symbols with an implicit negation > are quite horrible for the brain to understand

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Christoph Hellwig
On Sun, Feb 11, 2007 at 06:34:31AM +, Al Viro wrote: > +config NO_IOPORT > + bool > + default n please make this IOPORT. config symbols with an implicit negation are quite horrible for the brain to understand. - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Randy Dunlap
On Sun, 11 Feb 2007 06:34:31 + Al Viro wrote: > My current version: > > >From 97f115834b5ebef4f04e0f18aaa10f78f43733a0 Mon Sep 17 00:00:00 2001 > From: Al Viro <[EMAIL PROTECTED]> > Date: Sat, 10 Feb 2007 23:41:09 -0500 > Subject: [PATCH] sort the devres mess out > > Split the implementation

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Tejun Heo
Al Viro wrote: My current version: From 97f115834b5ebef4f04e0f18aaa10f78f43733a0 Mon Sep 17 00:00:00 2001 From: Al Viro <[EMAIL PROTECTED]> Date: Sat, 10 Feb 2007 23:41:09 -0500 Subject: [PATCH] sort the devres mess out Split the implementation-agnostic stuff in separate files. Make sure that t

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Al Viro
On Sun, Feb 11, 2007 at 01:26:40AM -0500, Tejun Heo wrote: > Christoph Hellwig wrote: > >I haven't looked at what causes it, but any leakage of pci details > >into io.h is bogus. I'd suggest that the original submitter fixes > >up that problem instead. > > pci_iomap() depends on two things - PCI

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Tejun Heo
Christoph Hellwig wrote: I haven't looked at what causes it, but any leakage of pci details into io.h is bogus. I'd suggest that the original submitter fixes up that problem instead. pci_iomap() depends on two things - PCI and iomap. AFAIK, there is no config to test whether the current arch

Re: [patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Christoph Hellwig
On Sat, Feb 10, 2007 at 12:45:50PM +0100, Heiko Carstens wrote: > From: Heiko Carstens <[EMAIL PROTECTED]> > > 9ac7849e35f705830f7b016ff272b0ff1f7ff759 causes this: > > CC arch/s390/mm/ioremap.o > In file included from arch/s390/mm/ioremap.c:18: > include/linux/io.h:46: > warning: "s

[patch] linux/io.h: forward declare struct pci_dev

2007-02-10 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> 9ac7849e35f705830f7b016ff272b0ff1f7ff759 causes this: CC arch/s390/mm/ioremap.o In file included from arch/s390/mm/ioremap.c:18: include/linux/io.h:46: warning: "struct pci_dev" declared inside parameter list include/linux/io.h:46: w